mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pedro Larroy <pedro.larroy.li...@gmail.com>
Subject Order of includes in cpplint
Date Tue, 08 Jan 2019 22:44:21 GMT
Hi MXNet community

cpplint seems to complain when the order of includes is not  [own,
system, other]

But the general best practice in C++ is [own, project, 3rd party,
system] for the reasons explained in this stackoverflow answer:  (
https://stackoverflow.com/questions/614302/c-header-order )

A contribution to cpplint could be made to make this configurable:

https://github.com/cpplint/cpplint/blob/master/cpplint.py#L605

Thoughts?

Pedro.

Mime
View raw message