From dev-return-5150-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Thu Dec 13 02:23:48 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4F66C18064E for ; Thu, 13 Dec 2018 02:23:48 +0100 (CET) Received: (qmail 36439 invoked by uid 500); 13 Dec 2018 01:23:47 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 36420 invoked by uid 99); 13 Dec 2018 01:23:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Dec 2018 01:23:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DBAAC180CDB for ; Thu, 13 Dec 2018 01:23:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.798 X-Spam-Level: * X-Spam-Status: No, score=1.798 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id yHW9lmo6VNvL for ; Thu, 13 Dec 2018 01:23:44 +0000 (UTC) Received: from mail-it1-f177.google.com (mail-it1-f177.google.com [209.85.166.177]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 894FF61064 for ; Thu, 13 Dec 2018 01:17:47 +0000 (UTC) Received: by mail-it1-f177.google.com with SMTP id g76so1356165itg.2 for ; Wed, 12 Dec 2018 17:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=p9ioPAE00nI58cc8MTHSJvSdlLSSUDB/yzGqKcEr2jk=; b=J2veTC4V2e5qQ8eAirwzogbLxcICLc40jhJCkhWJv7CirMWsakc1mi5rDDUgm1VYbg uAGrmJhyFbRfBfuwOcId7GcSZbXPlLMwccCeUJbVkps0n1QATeevAkkswPUX7fmQ5OcJ soeX6rorzTexPdo8kTQQa/efMH1NOEUhxRNHIqnyhcMlAsl9Cbra631eoSbXj25Hhac0 +vUhNcC3pD+s87n4ZXMLTP/W7TxqHr0V53DW5PPUILVmte7+mIiD7mW37c/51hyuiGhM s8xLD0LP2EVJm00KldEZj7iLXPmRO+Y4lSPjpQ75See5fhCYT9fRy+wIyOOuuZvUs7xa 6E0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=p9ioPAE00nI58cc8MTHSJvSdlLSSUDB/yzGqKcEr2jk=; b=FoL63YV8kc71lUqb9pK9dK0Ca0Jw8bo/gBCAsC8OZYHLKaLdSEZVni2UKGoXzn9xnD O8EbqiopNh/Gl9qOr+8zmdaQf8ukMCdsOrq5eFU4Ypi9RlPDBQ6qv35NrLkb3h9hUsAM ZAR0xHwoCSXMCLvRhAmUxVE27FtQ690z6bOZg4VgdPW1PFX3pDMbcoEJTXeODttBNr93 u1iEE00uD0jxjHJQIPKp0ljtoy3Cz9joEYVaTLBdMYKTNdUJ6Yf85t+vIvo/OIKSub9S MvU+P8MTudhDDhQI2oJMmyWAbwcrnAQAQe9POIrtNPxhyAXz1YndgyeSEIO4NNHgHfWp raCw== X-Gm-Message-State: AA+aEWap9OKXNBAQh1nQhbl2JbrYzVdBUGf17jR9ZNaehxrrta9O1qAD RIiFov+UXJmd2WYSBWGSvd9kP5k9xEnOcxb+ThjTzQ== X-Google-Smtp-Source: AFSGD/WYkmJKGfLG6uAarBz5elntUmlEWs9W0rWzQeX6RCqnlf6vyIfNA+zqYibXRzeQ6PFDIflfWn1N/s+/XvrUlf4= X-Received: by 2002:a24:3391:: with SMTP id k139mr7833873itk.25.1544663866499; Wed, 12 Dec 2018 17:17:46 -0800 (PST) MIME-Version: 1.0 References: <599F85A2-0576-449D-89EB-1317BDE3B070@live.com> In-Reply-To: <599F85A2-0576-449D-89EB-1317BDE3B070@live.com> From: Carin Meier Date: Wed, 12 Dec 2018 20:17:35 -0500 Message-ID: Subject: Re: [DISCUSS] About the PR merging policy To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="0000000000000f6af4057cdd15ec" --0000000000000f6af4057cdd15ec Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Qing - thanks for bringing this up. I think it would be a good thing to have a document on the wiki to help with these sorts of questions. In fact, since the project is growing with more new committers, maybe we could use a "New Committer Guide" with the process of how to get going and any FAQ like this one ... Would you be interested in getting a rough draft going of your recent experience? Then others can help collaborate on it. It would be nice to make the path smoother for other new committers to the project. Best, Carin On Tue, Dec 11, 2018 at 7:18 PM Qing Lan wrote: > Hi all, > > Recently I self-merged my PR without getting approvals from other > committers https://github.com/apache/incubator-mxnet/pull/13617 and only > contributors approval. I apologize to the community and thank Marco for > pointing out the problem. I took a lesson that we should at least have on= e > committer=E2=80=99s approval to merge the code. However, I just found thi= s section > is missing in the CWiki > https://cwiki.apache.org/confluence/display/MXNET/Become+an+Apache+MXNet+= %28incubating%29+Committer+and+PPMC+Member. > So I would like to discuss in here: > > How to conduct the PR reviewing/merging. How many approvals (Committers > and Contributors) we should get in order to merge? > > How to deal with disagreement in the discussion (e.g a > contributor/committer request a change)? > > Please don=E2=80=99t hesitate to share your thoughts! > > Thanks, > Qing > --0000000000000f6af4057cdd15ec--