From dev-return-5157-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Fri Dec 14 20:59:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 93235180645 for ; Fri, 14 Dec 2018 20:59:11 +0100 (CET) Received: (qmail 58478 invoked by uid 500); 14 Dec 2018 19:59:10 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 58461 invoked by uid 99); 14 Dec 2018 19:59:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Dec 2018 19:59:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A5E0BC1DF7 for ; Fri, 14 Dec 2018 19:59:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.797 X-Spam-Level: * X-Spam-Status: No, score=1.797 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id EGtjV2LfLCKL for ; Fri, 14 Dec 2018 19:59:07 +0000 (UTC) Received: from mail-it1-f177.google.com (mail-it1-f177.google.com [209.85.166.177]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 12F9460E0E for ; Fri, 14 Dec 2018 19:52:08 +0000 (UTC) Received: by mail-it1-f177.google.com with SMTP id c9so11238837itj.1 for ; Fri, 14 Dec 2018 11:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=2VIHPrURekc9AjmDw0nubIHBUzP20D4qvm4Zv2xxgzY=; b=uFSfKndO3RskVDIkJKwle9m9hZOWvf8ypz0O5IMe8TzI1ng3HvzwmuLJuVuqlX/8a1 gRCsDEKksbAJ0xdkI27CwdR6AGa1lZDipyyBPKNjIcwAHJpWa3DaRYqWxwVl2u1bzUfn qv9UYTIywycAUCgw5f9e8miyOfWqyMS9MG0DJdfvO+ZPgrHaYx5vgJePdrgq0hY0vxfk /K2ws6/vSgCWAj6a0uqrNGtpXhK4Y2fpgDtgT1G2CN0OIA3M95jLW73U3MnHXNJ4CPK4 JOtkqNdTBLgnGVshaq5BVYOBR0FP5HdmkazcrZ4wwIh4p0u+4oCyxIGDmCsB8xRRt3+4 qmsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=2VIHPrURekc9AjmDw0nubIHBUzP20D4qvm4Zv2xxgzY=; b=AF3QlQ7m9HDLQjNqJdZ1HMEQMjDA5/1zT4AU6K7/0woONo1vGXaYdbRdwELmTuWtg2 Ed+l16h37S57pHAPXafpPcaa1rpp2nKIA8ExX3R4yn2mSgNRyTUAGjhD6DBSlPr1MNgS dVD/28lP4Ef+ZxqT38lV9coimtk0ed/LHVGtsdPFpmhqFSvijZFYHfhpttZwprskxddt 5PxciLn9n1arez6v/HAMoWXvT9mBda6WXcyvHKArxkgfALhSnX3LtP4hetc/IkhAYt5U ZOOvT3Yf5sx8QqYrFgeMGec1lMaIoMD0/r4B6d3/kDrQcoeOSW5b4yD5b6WlKqp54elH PxSw== X-Gm-Message-State: AA+aEWYem3uD7r78n86Kf+6hKwiAr4foyO+vHAGQLT7SfaJl7zIK7073 UOOTiTFv9fQA+P/9qvfo2qVT8ZLWfj9RaWH2vTYSbL7Y X-Google-Smtp-Source: AFSGD/UOgVqD2IOL+aENIxhTBM1uhCtjwxqFQLqPwsbRU46VMOppNifyRzkthIZHp03KdlKWcXtxHO4maDKgP4WTUSI= X-Received: by 2002:a24:3391:: with SMTP id k139mr4301137itk.25.1544817121122; Fri, 14 Dec 2018 11:52:01 -0800 (PST) MIME-Version: 1.0 References: <599F85A2-0576-449D-89EB-1317BDE3B070@live.com> In-Reply-To: From: Carin Meier Date: Fri, 14 Dec 2018 14:51:50 -0500 Message-ID: Subject: Re: [DISCUSS] About the PR merging policy To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="000000000000bf6069057d00c3e6" --000000000000bf6069057d00c3e6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks Steffen, I had remembered reading that but couldn't find it again :) So yes - maybe we can duplicate that section and/or provide a link to a new committers guide. I'm thinking it should go on the community page here https://cwiki.apache.org/confluence/display/MXNET/Community Eventually, some of information collected there could migrate out the webpage as well. - Carin On Thu, Dec 13, 2018 at 7:30 AM Steffen Rochel wrote: > We do have already a guide which covers the issue: > > https://cwiki.apache.org/confluence/display/MXNET/Development+Process#Dev= elopmentProcess-GuidelinesforReviewers/Committers > < > https://cwiki.apache.org/confluence/display/MXNET/Development+Process#Dev= elopmentProcess-GuidelinesforReviewers/Committers > >, > but it probably needs to become more prominent. Any suggestion for a good > place? > Steffen > > On Wed, Dec 12, 2018 at 5:23 PM Carin Meier wrote: > > > Qing - thanks for bringing this up. > > > > I think it would be a good thing to have a document on the wiki to help > > with these sorts of questions. > > > > In fact, since the project is growing with more new committers, maybe w= e > > could use a "New Committer Guide" with the process of how to get going > and > > any FAQ like this one ... > > > > Would you be interested in getting a rough draft going of your recent > > experience? Then others can help collaborate on it. > > > > It would be nice to make the path smoother for other new committers to > the > > project. > > > > Best, > > Carin > > > > On Tue, Dec 11, 2018 at 7:18 PM Qing Lan wrote: > > > > > Hi all, > > > > > > Recently I self-merged my PR without getting approvals from other > > > committers https://github.com/apache/incubator-mxnet/pull/13617 and > only > > > contributors approval. I apologize to the community and thank Marco f= or > > > pointing out the problem. I took a lesson that we should at least hav= e > > one > > > committer=E2=80=99s approval to merge the code. However, I just found= this > > section > > > is missing in the CWiki > > > > > > https://cwiki.apache.org/confluence/display/MXNET/Become+an+Apache+MXNet+= %28incubating%29+Committer+and+PPMC+Member > > . > > > So I would like to discuss in here: > > > > > > How to conduct the PR reviewing/merging. How many approvals (Committe= rs > > > and Contributors) we should get in order to merge? > > > > > > How to deal with disagreement in the discussion (e.g a > > > contributor/committer request a change)? > > > > > > Please don=E2=80=99t hesitate to share your thoughts! > > > > > > Thanks, > > > Qing > > > > > > --000000000000bf6069057d00c3e6--