mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carin Meier <>
Subject Re: [DISCUSS] About the PR merging policy
Date Thu, 13 Dec 2018 01:17:35 GMT
Qing - thanks for bringing this up.

I think it would be a good thing to have a document on the wiki to help
with these sorts of questions.

In fact, since the project is growing with more new committers, maybe we
could use a "New Committer Guide" with the process of how to get going and
any FAQ like this one ...

Would you be interested in getting a rough draft going of your recent
experience? Then others can help collaborate on it.

It would be nice to make the path smoother for other new committers to the


On Tue, Dec 11, 2018 at 7:18 PM Qing Lan <> wrote:

> Hi all,
> Recently I self-merged my PR without getting approvals from other
> committers and only
> contributors approval. I apologize to the community and thank Marco for
> pointing out the problem. I took a lesson that we should at least have one
> committer’s approval to merge the code. However, I just found this section
> is missing in the CWiki
> So I would like to discuss in here:
> How to conduct the PR reviewing/merging. How many approvals (Committers
> and Contributors) we should get in order to merge?
> How to deal with disagreement in the discussion (e.g a
> contributor/committer request a change)?
> Please don’t hesitate to share your thoughts!
> Thanks,
> Qing

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message