From dev-return-4727-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Tue Nov 6 22:51:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 92D2A180658 for ; Tue, 6 Nov 2018 22:51:50 +0100 (CET) Received: (qmail 17489 invoked by uid 500); 6 Nov 2018 21:51:49 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 17477 invoked by uid 99); 6 Nov 2018 21:51:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Nov 2018 21:51:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 891F618DCB7 for ; Tue, 6 Nov 2018 21:51:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.638 X-Spam-Level: ** X-Spam-Status: No, score=2.638 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, KAM_ADVERT2=0.75, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 0ThpUJpoQOXg for ; Tue, 6 Nov 2018 21:51:43 +0000 (UTC) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 704925F534 for ; Tue, 6 Nov 2018 21:51:42 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id 192-v6so11366692oii.6 for ; Tue, 06 Nov 2018 13:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=N1rCwBcysK2YktALyMTk+gQvg0dicUEIYMGKs9nWjP4=; b=Gel4Y6gZgZlmUdKwzqRMwOy4TZ5lmYUhLgIxkvOehuHV9E4gVirRySJZBlBAX+nNAi ogMF+ICylOQvyYy2uoXX4vDbFbliguWJ6YXKbQ9G+W5hdqOg8AdGzrch0aWIS6I1VsFN shLpY6ALaNaw5G0JDE/76VQcCh88vVJMrDXvqF59CBgL3croitIk9bFq/qAL2/KNRxpq 2B4puxLMXBzIMKFaFAQLwWSopDLWt2T/9oM269frqVA5U0dFWuRiSwH/d1/Rc2zW067h E8tXAJQhvX/FhYrM7pEpEsA4PqUij2Zfls1DbzqL4EBnpiDMVRLVkznOsk/dx7CyJdNd rtoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=N1rCwBcysK2YktALyMTk+gQvg0dicUEIYMGKs9nWjP4=; b=TRSSmkhzsl28rLwTlnpquEVjildi28z9yjrJ6Dh22CIN7CsEkx1w6DJw+1Nwl8/ai3 Lv2sR79Q7HOogb9h+QImNV6elwK6FkVmP1M2KzNryxd9pwKopZS+GDtsZ8tF5aJFAWkF yWTuu9c9FsRnyKZuS3w990X0JtjPuhTnjfrPJPkSs7H6RULg1AJZSs7um5VSqDXtRPL5 aKlLQroW6MqUojFhp/3sCvHJGOFeDgfaL42nZME4iKk5/VP8TbfPlhmOIQv6PQtBv01Y djEGavAq1QnxKVXqjbKncnK+wxVcDVMaNJH5z1cvFuiz6Pbr3MmduM1xqXdS2d6vlPc+ dTDA== X-Gm-Message-State: AGRZ1gLn2K6w1505/h0aKFiPJ9EiaZg8AeeUz98RHSR4zICC8EU1wAm+ 4vdOjhhpwisxn5zl2a4IIGpso5KX9YvpQaXY8m2OYvp8c4M= X-Google-Smtp-Source: AJdET5eMaYiIym2UhkiENO6gj6lQLOKBquTLC6CpT/bec/2t0l/A4fnCuIU/9ZICBp/GzdS3r0FZp/x8KJhCfP664NQ= X-Received: by 2002:aca:5596:: with SMTP id j144-v6mr17231921oib.54.1541541100656; Tue, 06 Nov 2018 13:51:40 -0800 (PST) MIME-Version: 1.0 References: <05F52EF0-7BA4-42A9-B58B-8603FD36DED2@gmail.com> In-Reply-To: From: Aaron Markham Date: Tue, 6 Nov 2018 13:51:28 -0800 Message-ID: Subject: Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="000000000000b61e50057a0601ad" --000000000000b61e50057a0601ad Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Anton, I have the following suggestions for fixes to include in 1.3.1. These each have updates to files that will impact docs generation for the 1.3.x version of the website's Python API docs: https://github.com/apache/incubator-mxnet/pull/12879 https://github.com/apache/incubator-mxnet/pull/12871 https://github.com/apache/incubator-mxnet/pull/12856 Thanks, Aaron On Tue, Nov 6, 2018 at 1:29 PM Lai Wei wrote: > Hi Anton, > > Thanks for driving this, I would like to include the following fix in > 1.3.1: > Allow infer shape partial on foreach operator: > https://github.com/apache/incubator-mxnet/pull/12471 > > Keras-MXNet needs this functionality to infer shape partially > on foreach operator. (Used in RNN operators) > > Thanks a lot! > > > Best Regards > Lai Wei > > > > On Tue, Nov 6, 2018 at 10:44 AM Haibin Lin > wrote: > > > Hi Naveen and Anton, > > > > Thanks for pointing that out. You are right that these are not critical > > fixes. Putting them in 1.4.0 is more appropriate. PRs are closed. > > > > Best, > > Haibin > > > > On Tue, Nov 6, 2018 at 7:35 AM Naveen Swamy wrote: > > > > > Please note that this is a patch release(1.3.1) to address critical > > bugs!, > > > For everything else please wait for 1.4.0 which is planned very short= ly > > > after 1.3.1 > > > > > > > On Nov 6, 2018, at 7:17 AM, Anton Chernov > wrote: > > > > > > > > The following PR's have been created so far: > > > > > > > > Infer dtype in SymbolBlock import from input symbol (v1.3.x) > > > > https://github.com/apache/incubator-mxnet/pull/13117 > > > > > > > > [MXNET-953] Fix oob memory read (v1.3.x) > > > > https://github.com/apache/incubator-mxnet/pull/13118 > > > > > > > > [MXNET-969] Fix buffer overflow in RNNOp (v1.3.x) > > > > https://github.com/apache/incubator-mxnet/pull/13119 > > > > > > > > [MXNET-922] Fix memleak in profiler (v1.3.x) > > > > https://github.com/apache/incubator-mxnet/pull/13120 > > > > > > > > Set correct update on kvstore flag in dist_device_sync mode (v1.3.x= ) > > > > https://github.com/apache/incubator-mxnet/pull/13121 > > > > > > > > update mshadow (v1.3.x) > > > > https://github.com/apache/incubator-mxnet/pull/13122 > > > > > > > > CudnnFind() usage improvements (v1.3.x) > > > > https://github.com/apache/incubator-mxnet/pull/13123 > > > > > > > > Fix lazy record io when used with dataloader and multi_worker > 0 > > > (v1.3.x) > > > > https://github.com/apache/incubator-mxnet/pull/13124 > > > > > > > > > > > > As stated previously I would be rather opposed to have following PR= 's > > it > > > in > > > > the patch release: > > > > > > > > Gluon LSTM Projection and Clipping Support (#13055) v1.3.x > > > > https://github.com/apache/incubator-mxnet/pull/13129 > > > > > > > > sample_like operators (#13034) v1.3.x > > > > https://github.com/apache/incubator-mxnet/pull/13130 > > > > > > > > > > > > Best > > > > Anton > > > > > > > > =D0=B2=D1=82, 6 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 16:06= , Anton Chernov : > > > > > > > >> Hi Haibin, > > > >> > > > >> I have a few comments regarding the proposed performance improveme= nt > > > >> changes. > > > >> > > > >> CUDNN support for LSTM with projection & clipping > > > >> https://github.com/apache/incubator-mxnet/pull/13056 > > > >> > > > >> There is no doubt that this change brings value, but I don't see i= t > > as a > > > >> critical bug fix. I would rather leave it for the next major > release. > > > >> > > > >> sample_like operators > > > >> https://github.com/apache/incubator-mxnet/pull/13034 > > > >> > > > >> Even if it's related to performance, this is an addition of > > > functionality > > > >> and I would also push this to be in the next major release only. > > > >> > > > >> > > > >> Best > > > >> Anton > > > >> > > > >> > > > >> =D0=B2=D1=82, 6 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 15:5= 5, Anton Chernov : > > > >> > > > >>> Hi Patric, > > > >>> > > > >>> This change was listed in the 'PR candidates suggested for > > > consideration > > > >>> for v1.3.1 patch release' section [1]. > > > >>> > > > >>> You are right, I also think that this is not a critical hotfix > change > > > >>> that should be included into the 1.3.1 patch release. > > > >>> > > > >>> Thus I'm not making any further efforts to bring it in. > > > >>> > > > >>> Best > > > >>> Anton > > > >>> > > > >>> [1] > > > >>> > > > > > > https://cwiki.apache.org/confluence/display/MXNET/Project+Proposals+for+n= ext+MXNet+Release#PR_candidates > > > >>> > > > >>> > > > >>> =D0=B2=D1=82, 6 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 1:1= 4, Zhao, Patric : > > > >>> > > > >>>> Hi Anton, > > > >>>> > > > >>>> Thanks for looking into the MKL-DNN PR. > > > >>>> > > > >>>> As my understanding of cwiki ( > > > >>>> > > > > > > https://cwiki.apache.org/confluence/display/MXNET/Project+Proposals+for+n= ext+MXNet+Release > > > >>>> ), > > > >>>> these features will go into 1.4 rather than patch release of > 1.3.1. > > > >>>> > > > >>>> Feel free to correct me :) > > > >>>> > > > >>>> Thanks, > > > >>>> > > > >>>> --Patric > > > >>>> > > > >>>>> -----Original Message----- > > > >>>>> From: Anton Chernov [mailto:mechernov@gmail.com] > > > >>>>> Sent: Tuesday, November 6, 2018 3:11 AM > > > >>>>> To: dev@mxnet.apache.org > > > >>>>> Subject: Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.= 1 > > > patch > > > >>>>> release > > > >>>>> > > > >>>>> It seems that there is a problem porting following changes to t= he > > > >>>> v1.3.x > > > >>>>> release branch: > > > >>>>> > > > >>>>> Implement mkldnn convolution fusion and quantization > > > >>>>> https://github.com/apache/incubator-mxnet/pull/12530 > > > >>>>> > > > >>>>> MKL-DNN Quantization Examples and README > > > >>>>> https://github.com/apache/incubator-mxnet/pull/12808 > > > >>>>> > > > >>>>> The bases are different. > > > >>>>> > > > >>>>> I would need help from authors of these changes to make a > backport > > > PR. > > > >>>>> > > > >>>>> @ZhennanQin, @xinyu-intel would you be able to assist me and > create > > > the > > > >>>>> corresponding PR's? > > > >>>>> > > > >>>>> Without proper history and domain knowledge I would not be able > to > > > >>>> create > > > >>>>> them by my own in reasonable amount of time, I'm afraid. > > > >>>>> > > > >>>>> Best regards, > > > >>>>> Anton > > > >>>>> > > > >>>>> =D0=BF=D0=BD, 5 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 1= 9:45, Anton Chernov >: > > > >>>>> > > > >>>>>> > > > >>>>>> As part of: > > > >>>>>> > > > >>>>>> Implement mkldnn convolution fusion and quantization > > > >>>>>> https://github.com/apache/incubator-mxnet/pull/12530 > > > >>>>>> > > > >>>>>> I propose to add the examples and documentation PR as well: > > > >>>>>> > > > >>>>>> MKL-DNN Quantization Examples and README > > > >>>>>> https://github.com/apache/incubator-mxnet/pull/12808 > > > >>>>>> > > > >>>>>> > > > >>>>>> Best regards, > > > >>>>>> Anton > > > >>>>>> > > > >>>>>> =D0=BF=D0=BD, 5 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 = 19:02, Anton Chernov >: > > > >>>>>> > > > >>>>>>> Dear MXNet community, > > > >>>>>>> > > > >>>>>>> I will be the release manager for the upcoming 1.3.1 patch > > release. > > > >>>>>>> Naveen will be co-managing the release and providing help fro= m > > the > > > >>>>>>> committers side. > > > >>>>>>> > > > >>>>>>> The following dates have been set: > > > >>>>>>> > > > >>>>>>> Code Freeze: 31st October 2018 > > > >>>>>>> Release published: 13th November 2018 > > > >>>>>>> > > > >>>>>>> Release notes have been drafted here [1]. > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> * Known issues > > > >>>>>>> > > > >>>>>>> Update MKL-DNN dependency > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12953 > > > >>>>>>> > > > >>>>>>> This PR hasn't been merged even to master yet. Requires > > additional > > > >>>>>>> discussion and merge. > > > >>>>>>> > > > >>>>>>> distributed kvstore bug in MXNet > > > >>>>>>> https://github.com/apache/incubator-mxnet/issues/12713 > > > >>>>>>> > > > >>>>>>>> When distributed kvstore is used, by default gluon.Trainer > > doesn't > > > >>>>>>>> work > > > >>>>>>> with mx.optimizer.LRScheduler if a worker has more than 1 GPU= . > To > > > be > > > >>>>>>> more specific, the trainer updates once per GPU, the > LRScheduler > > > >>>>>>> object is shared across GPUs and get a wrong update count. > > > >>>>>>> > > > >>>>>>> This needs to be fixed. [6] > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> * Changes > > > >>>>>>> > > > >>>>>>> The following changes will be ported to the release branch, p= er > > > [2]: > > > >>>>>>> > > > >>>>>>> Infer dtype in SymbolBlock import from input symbol [3] > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12412 > > > >>>>>>> > > > >>>>>>> [MXNET-953] Fix oob memory read > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12631 > > > >>>>>>> > > > >>>>>>> [MXNET-969] Fix buffer overflow in RNNOp > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12603 > > > >>>>>>> > > > >>>>>>> [MXNET-922] Fix memleak in profiler > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12499 > > > >>>>>>> > > > >>>>>>> Implement mkldnn convolution fusion and quantization (MXNet > Graph > > > >>>>>>> Optimization and Quantization based on subgraph and MKL-DNN > > > >>>>> proposal > > > >>>>>>> [4]) > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12530 > > > >>>>>>> > > > >>>>>>> Following items (test cases) should be already part of 1.3.0: > > > >>>>>>> > > > >>>>>>> [MXNET-486] Create CPP test for concat MKLDNN operator > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/11371 > > > >>>>>>> > > > >>>>>>> [MXNET-489] MKLDNN Pool test > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/11608 > > > >>>>>>> > > > >>>>>>> [MXNET-484] MKLDNN C++ test for LRN operator > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/11831 > > > >>>>>>> > > > >>>>>>> [MXNET-546] Add unit test for MKLDNNSum > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/11272 > > > >>>>>>> > > > >>>>>>> [MXNET-498] Test MKLDNN backward operators > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/11232 > > > >>>>>>> > > > >>>>>>> [MXNET-500] Test cases improvement for MKLDNN on Gluon > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/10921 > > > >>>>>>> > > > >>>>>>> Set correct update on kvstore flag in dist_device_sync mode (= as > > > part > > > >>>>>>> of fixing [5]) > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12786 > > > >>>>>>> > > > >>>>>>> upgrade mshadow version > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12692 > > > >>>>>>> But another PR will be used instead: > > > >>>>>>> update mshadow > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12674 > > > >>>>>>> > > > >>>>>>> CudnnFind() usage improvements > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12804 > > > >>>>>>> A critical CUDNN fix that reduces GPU memory consumption and > > > >>>>>>> addresses this memory leak issue. This is an important fix to > > > >>>> include > > > >>>>>>> in 1.3.1 > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> From discussion about gluon toolkits: > > > >>>>>>> > > > >>>>>>> disable opencv threading for forked process > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12025 > > > >>>>>>> > > > >>>>>>> Fix lazy record io when used with dataloader and multi_worker > > 0 > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12554 > > > >>>>>>> > > > >>>>>>> fix potential floating number overflow, enable float16 > > > >>>>>>> https://github.com/apache/incubator-mxnet/pull/12118 > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> * Resolved issues > > > >>>>>>> > > > >>>>>>> MxNet 1.2.1=E2=80=93module get_outputs() > > > >>>>>>> https://discuss.mxnet.io/t/mxnet-1-2-1-module-get-outputs/188= 2 > > > >>>>>>> > > > >>>>>>> As far as I can see from the comments the issue has been > > resolved, > > > >>>> no > > > >>>>>>> actions need to be taken for this release. [7] is mentioned i= n > > this > > > >>>>>>> regards, but I don't see any action points here either. > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> I will start with help of Naveen port the mentioned PR's to t= he > > > >>>> 1.3.x > > > >>>>>>> branch. > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> Best regards, > > > >>>>>>> Anton > > > >>>>>>> > > > >>>>>>> [1] https://cwiki.apache.org/confluence/x/eZGzBQ > > > >>>>>>> [2] > > > >>>>>>> > > > >>>> > > https://cwiki.apache.org/confluence/display/MXNET/Project+Proposals+f > > > >>>>>>> or+next+MXNet+Release [3] > > > >>>>>>> https://github.com/apache/incubator-mxnet/issues/11849 > > > >>>>>>> [4] > > > >>>>>>> > > > >>>>> > > > https://cwiki.apache.org/confluence/display/MXNET/MXNet+Graph+Optimiz > > > >>>>>>> ation+and+Quantization+based+on+subgraph+and+MKL-DNN > > > >>>>>>> [5] https://github.com/apache/incubator-mxnet/issues/12713 > > > >>>>>>> [6] > > > >>>>>>> https://github.com/apache/incubator- > > > >>>>> mxnet/issues/12713#issuecomment-4 > > > >>>>>>> 35773777 [7] > > https://github.com/apache/incubator-mxnet/pull/11005 > > > >>>>>>> > > > >>>>>>> > > > >>>> > > > >>> > > > > > > --000000000000b61e50057a0601ad--