mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <>
Subject Re: Updating MXNet's Cub
Date Mon, 19 Nov 2018 22:04:01 GMT
I created a PR to address this issue:

Simply change cub submodule's URL will impact every developer. The recommended command: "git
submodule update" won't work. Developer has to run "git submodule sync" first.

To minimize the impact, I deleted CUB submodule and added a new submodule: "nvidia_cub". the
only side effect is there will be a dangling untracked folder "cub" in local disk. Developer
can delete it manually.


On 2018/08/24 17:00:54, Hagay Lupesko <> wrote: 
> Hi all,
> One of MXNet’s submodule dependencies is a snapshot of Nvidia Cub (
> – the snapshot is of an older version of Cub
> (1.7), while the latest Nvidia Cub release is 1.8.  Note that dmlc/cub has
> no customizations of the source Cub repo.
> I’d like to suggest to update the existing Cub submodule to Nvidia’s Cub
> repo. Instead of the snapshot, MXNet will be using Nvidia’s repo and the
> latest release (both repos have the same BSD-3 license, so licensing should
> not be an issue).
> Wanted to get feedback from the community to make sure I'm not missing
> anything.
> if there are no objections I'll submit a PR for the change.
> Cheers,
> Hagay

View raw message