mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steffen Rochel <steffenroc...@gmail.com>
Subject Re: LabelBot New Design in Production
Date Sat, 17 Nov 2018 17:12:05 GMT
+1 for the proposal

Thanks Harsh for your initiative to improve the productivity of the
community.

I agree with Sheng that care needs to be taken using the proposed label
appropriately.
Having a committer to actually close the issue is therefor a good gate.

However, I'm in favor of such label and see additional l value in addition
to the supporting arguments from others :
1. We used the approach to close issues automatically if "open for a long
time" in the past, which in my view was even less welcoming then the
proposed label.
2. Adding a label informs the authors that the community suggest to close
the issue
2. gives him/her or other members of the community the opportunity to
respond. We could even agree for a certain grace period before the issue
actually gets closed or other mechanism to address the risk an issues gets
closed prematurely. (which in itself can easily be reverted).
3. potentially enables further automation in the future (i.e. issue does
get closed by a bot if there was not action XX days after the label was
added).
4. proposed label provides consistency as added value vs. "some existing
label" + "for a long time".
5. The proposal is not irreversible.

I  don't think we should invest effort to create wiki + automatic updates.
Having the label allows for simple search + enables to use the querying
capabilities of github and give visibility to the community about a
proposal to close an issue in a consistent way.

Sheng - are you open to try the proposed label for a certain time or should
we get together on Monday in the office, hash out an acceptable proposal
and report back to the community?

Regards,
Steffen

On Fri, Nov 16, 2018 at 12:45 PM sandeep krishnamurthy <
sandeep.krishna98@gmail.com> wrote:

> I believe having this label - [suggest-closed] is helpful.
>
> 1. Adding this label is not an automated bot script that marks stale
> issues. A bot script would definitely be unwelcoming and also miss major
> issues just because it is stale.
> 2. This label is simply a way to identify issues that can be closed. There
> are many community members who submits PRs/suggest steps for the fix but
> cannot actually close the issue when deemed appropriate. Right now, a
> committer is tagged on the issue to be closed. With this label, any
> committer can see issues with this label and take appropriate action.
> 3. From what I see, community members are going through the issues,
> submitting the fix, responding with solutions or questions, waiting for
> confirmation and finally, label the issue. So I do not see why this is
> unwelcoming.
> 4. This label is not just for stale issues. This is simply a label to allow
> more committers to easily keep issues folder tidy in collaboration with
> community members.
>
> Best,
> Sandeep
>
>
>
> On Fri, Nov 16, 2018 at 11:52 AM Sheng Zha <szha.pvg@gmail.com> wrote:
>
> > Thanks, Harsh. I saw that this was created and used on several issues
> and I
> > removed it for now because:
> >
> > - the issues that they are used on issues that don't seem to be resolved.
> >
> > - it leaves the impression to the requesters that people think their
> issues
> > are not worth people's attention in this community, which seems
> > unwelcoming.
> >
> > - it seems to be equivalent to issues "some existing label" + "for a long
> > time", which means it doesn't add value to classifying the issues.
> >
> >
> > If the goal is to identify stale issues, how about create an issue or a
> > wiki page, and have a script to update the stale issue list periodically?
> > This way, committers can always go visit that issue/wikipage and help
> with
> > the stale issues. It also forms the basis for a public dashboard for
> other
> > aspects of the project, which is likely worthwhile.
> >
> >
> > What do you think?
> >
> >
> >
> > Best regards,
> >
> > -sz
> >
> > On Fri, Nov 16, 2018 at 11:41 AM Harsh Patel <harshpatel081296@gmail.com
> >
> > wrote:
> >
> > > Hey all,
> > > To help with how we handle issues for MXNet, I am proposing a new label
> > be
> > > created called: [suggest-closed]. I, alongside many others, observe
> many
> > > stale issues which can be candidates for closure and searching for
> these
> > of
> > > the 800+ issues we have is a daunting task. This label is meant to help
> > tag
> > > issues which the community believes should be closed. To clarify, this
> is
> > > not meant to actually close issues, it is simply a suggestion which
> > > contributors can feel free to label. If I am able to get a committer to
> > > help create this that would be great!
> > >
> > > Best,
> > > -Harsh
> > >
> > > On Thu, Nov 8, 2018 at 11:28 PM Hagay Lupesko <lupesko@gmail.com>
> wrote:
> > >
> > > >
> > > > > improve over time (think about it recommending you to check out the
> > > > discuss
> > > > > forum when you ask a question, asking you to provide a minimum
> > > > reproducible
> > > > > example if you report a bug, etc). That way, we would reduce the
> > amount
> > > > > boilerplate in the issue template and at the same time provide the
> > user
> > > > > with custom tailored assistance.
> > > > >
> > > > > Best regards,
> > > > > Marco
> > > > >
> > > > > On Fri, Nov 9, 2018 at 1:00 AM Naveen Swamy <mnnaveen@gmail.com>
> > > wrote:
> > > > >
> > > > > > Great job!, this is very helpful to triage issues!, users when
> > > > creating a
> > > > > > new Issue could themselves tag the issues. May be we should
add
> > that
> > > to
> > > > > the
> > > > > > issue template?
> > > > > >
> > > > > > On Thu, Nov 8, 2018 at 3:54 PM Harsh Patel <
> > > harshpatel081296@gmail.com
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hey all,
> > > > > > > The upgraded label bot has been pushed into production.
Current
> > > > > > > functionality includes
> > > > > > > add, delete, and update.
> > > > > > > (i.e. @mxnet-label-bot add ['label']
> > > > > > > @mxnet-label-bot remove ['label']
> > > > > > > @mxnet-label-bot update ['label'])
> > > > > > >
> > > > > > > Users should feel free to leave suggestions and any potential
> > > issues.
> > > > > The
> > > > > > > forum to this best would be here:
> > > > > > > https://github.com/apache/incubator-mxnet/issues/13163
> > > > > > >
> > > > > > > Best,
> > > > > > > -Harsh Patel
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
> --
> Sandeep Krishnamurthy
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message