mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carin Meier <carinme...@gmail.com>
Subject Should PR-860 (Use modernized range loops where possible) be reverted?
Date Tue, 20 Nov 2018 13:48:55 GMT
My intent was to be helpful, but I think I may have merged this PR
yesterday too soon thinking it was approved and ready to merge
https://github.com/apache/incubator-mxnet/pull/12356

I didn't see the connected dev discussion
https://lists.apache.org/thread.html/b47f285a80bef47c5ead6c361614e338a0661f6c0c76196c1e3719c5@%3Cdev.mxnet.apache.org%3E
where there were -1 votes, which I believe are vetos?

So the question is confirm: should PR should be reverted?

Sorry for any confusion,
Carin

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message