From dev-return-4551-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Mon Oct 22 05:30:26 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D9C9418065D for ; Mon, 22 Oct 2018 05:30:25 +0200 (CEST) Received: (qmail 89946 invoked by uid 500); 22 Oct 2018 03:30:24 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 89932 invoked by uid 99); 22 Oct 2018 03:30:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 03:30:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CB683180AE4 for ; Mon, 22 Oct 2018 03:30:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -11.001 X-Spam-Level: X-Spam-Status: No, score=-11.001 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=2, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dvUL5z-Dbh0z for ; Mon, 22 Oct 2018 03:30:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id C74AF5F49F for ; Mon, 22 Oct 2018 03:30:20 +0000 (UTC) Received: (qmail 89929 invoked by uid 99); 22 Oct 2018 03:30:20 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 03:30:20 +0000 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id D8ACBA53 for ; Mon, 22 Oct 2018 03:30:18 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id o17-v6so7993487wmh.0 for ; Sun, 21 Oct 2018 20:30:18 -0700 (PDT) X-Gm-Message-State: ABuFfohqC0gbC9soClCsSjp0hzzN0XBBtRGq3gBoRV4/HaPKUBDusaYU gROoDFDQ5f654whGHGx42azu87aUlIJ2iUMKZB0= X-Google-Smtp-Source: ACcGV62b9aL4Ih9bbX4WYwrYIeQXBrPx0eQorHDmqAmA8x31s0iXVr+wyibH379JySv6j94nXPz5Ub/56bw0YRSv1jk= X-Received: by 2002:a1c:7ed4:: with SMTP id z203-v6mr13700685wmc.62.1540179017789; Sun, 21 Oct 2018 20:30:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tianqi Chen Date: Sun, 21 Oct 2018 20:30:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Discussion] Recognise Reviewers, Besides Committers and PMC To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="0000000000003ef80e0578c8df0b" --0000000000003ef80e0578c8df0b Content-Type: text/plain; charset="UTF-8" I was suggesting something more concrete: - Add a Reviewers section to https://github.com/apache/incubator-mxnet/blob/master/CONTRIBUTORS.md to list a list of Reviewers. - This is a "pesudo role", but holds weight as committers should highly value their reviews during the PR process. - The committers/PMC could actively look for good contributors and nominate them as Reviewer. - Contributors are encouraged to seek reviews from the list of reviewers. - The committers should actively solicit code reviews from the reviewers when reviewing PRs and take their reviews into serious consideration. - PMCs should actively look for new committers in the current Reviewers - Notably, the history reviews plus contribution likely will provide a good indication on whether the person can uphold the quality standard of the codebase, and provide helpful feedbacks(which is the trait that needed from committer to merge code) Tianqi On Sun, Oct 21, 2018 at 5:13 PM Steffen Rochel wrote: > +1 > With the release announcement for MXNet 1.3 all contributors incl. code > reviewers have been recognized. I suggest all future release announcements > should include such recognition. Are you suggesting to highlight most > active reviewers in release announcement or regularly (e.g. monthly), > specifically from non-committers? > > On Sun, Oct 21, 2018 at 10:11 AM Tianqi Chen wrote: > > > Also re another email-thread(I sent out one with my institutional email > > which get blocked initially, so this one was a bit duplication of that). > I > > think it should really be the job of committers to recognize potential > > reviewers, github also makes it easier to do so, e.g. > > > > > https://github.com/apache/incubator-mxnet/pulls?utf8=%E2%9C%93&q=reviewed-by%3Apiiswrong > > > > Tianqi > > > > On Fri, Oct 19, 2018 at 12:05 PM Carin Meier > wrote: > > > > > +1 Great idea. Adding a name to the contributor list is a good idea. > > Also, > > > I've found that thanking the person for the review on the PR is another > > way > > > to express gratitude for their time and effort. > > > > > > On Fri, Oct 19, 2018 at 2:51 PM Tianqi Chen wrote: > > > > > > > Dear MXNet Community: > > > > > > > > There is a great discussion going on in terms of lowering the barrier > > of > > > > entries and encourage more contribution to the project. One of the > > > general > > > > goals is to encourage a broader pool of contributions. I want to make > > the > > > > following proposal: > > > > > > > > Besides Committers and PMC, let us also recognize Reviewers in the > > > > community. This is a "pseudo role" as there is no such official role > > in > > > > Apache. But I want to explore the possibility of recognizing active > > > > reviewers for example, by adding a list of names in the contributor > > list. > > > > In general, I find it is really helpful to have more code reviews. > > > > Recognizing good reviewers early enables us to find committer > > candidates, > > > > and encourage them to contribute and understand what is the bar of > code > > > > quality that is required to merge the code. > > > > > > > > This can provide the community with more evidence when recruiting new > > > > committers. After all the write access of committership is about to > the > > > > code and understand the consequence of the responsibility -- which is > > > > usually can be found in high-quality review history. > > > > > > > > Please let me know what you think. > > > > > > > > Tianqi > > > > > > > > > > --0000000000003ef80e0578c8df0b--