From dev-return-4559-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Mon Oct 22 22:09:23 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D53F118064A for ; Mon, 22 Oct 2018 22:09:22 +0200 (CEST) Received: (qmail 99332 invoked by uid 500); 22 Oct 2018 20:09:22 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 99320 invoked by uid 99); 22 Oct 2018 20:09:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 20:09:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E9C001A0FAA for ; Mon, 22 Oct 2018 20:09:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.138 X-Spam-Level: ** X-Spam-Status: No, score=2.138 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id DNlgyphrAT85 for ; Mon, 22 Oct 2018 20:09:18 +0000 (UTC) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2D5C15F386 for ; Mon, 22 Oct 2018 20:09:18 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id y20-v6so39164399eds.10 for ; Mon, 22 Oct 2018 13:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=OnWQEwM17wnhGsQfNHvMuHjWADo98x8urM8wJveghf4=; b=ksMqmy9ySoPBpO+ROT6zVoA/EQZATfVQt3zIstn1lePzN6RSdYyBWjiG7LAmVBGKfU uLeYyIy3+izxMw3QJY8akLnQLhKF+IFbxkKkZrbmBLQE3Sx4YUsHrIAd+ITevpwuumeM bwtd1wgNL+j/svovGl3bn8RsmekuwdRNSWFDwxyDmKiweKPZAM3k1fQ2szbcs+08oMgH ORCuZawqgaYD9Ab8hxtiB6v4PyxAMqBqDF3Cbyc7TcOGICd8SS3HG9L+8DMOZqvpD8Ir 9lBhxEgghyZkRSSiJNuPbtpBFuTNd1cvHVxdec4EFUVRUQMEKSwBYj8VM80sYizt3GUf 0AhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=OnWQEwM17wnhGsQfNHvMuHjWADo98x8urM8wJveghf4=; b=aUZ6ALE9BFIQWRti6MM3GRj7HbBSXu0dgxa1bjQ+eM8U8rt+QXhC06TK4Gma9p8sqV mSpKLZgsO7U7SnTOy6BfEoOJpUYzebKoo0V5wOeJt0l8J66BtISeiciopH//SBVtC9g2 9WCeI0+4mso5gZSuiyp/dTrMDX/RKPEy3TWBD6xINu1+CtBZSwWNYEtztAaTc5S4+j2f 96pHludEk0Ly3GGuHNpu+B+rA9nVEDyzSsmxRdY8sOXqBN+pFstE9QJoCcGkS2YDy3+R BX2xW5Z+QxC6wvwVpyMQ7okFR3d5TGxOVeGxFrwUIdDn3ZuoO/i+HmgXfl7K89wyDUnO v2Xg== X-Gm-Message-State: ABuFfogZAdsxAENOAe4rnPOwVJtd0nUJvvqcCp3ZVyl3xv4xrk4GhkvD Ot1cIB0IB+SxsqtHnFQSqS3Bih8LRDctZbgx4KOHfA== X-Google-Smtp-Source: ACcGV62i1LSaeTA3ikFjy10obVZg8Gh7g1gNz89q0ijTynOonA+ErBx0p7SfsyCfnxJ3FFKijqFqg1IiAhKnDNRvhn4= X-Received: by 2002:a17:906:48d:: with SMTP id f13-v6mr14388874eja.60.1540238951449; Mon, 22 Oct 2018 13:09:11 -0700 (PDT) MIME-Version: 1.0 References: <22CBAFB2-FC41-4026-8D5B-2A1B64F43D51@live.com> In-Reply-To: <22CBAFB2-FC41-4026-8D5B-2A1B64F43D51@live.com> From: Anirudh Date: Mon, 22 Oct 2018 13:09:03 -0700 Message-ID: Subject: Re: [Discussion] Recognise Reviewers, Besides Committers and PMC To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="000000000000920f4c0578d6d308" --000000000000920f4c0578d6d308 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable -1. I dont see the need for additional level of hierarchy. I totally am for recognizing good code reviewers. We can recognize this by making them committers. Being a good reviewer should be sufficient to become a committer in my opinion. (Assuming that there is a seperation between PPMC and committers). Anirudh On Mon, Oct 22, 2018 at 8:28 AM Qing Lan wrote: > +1 > Let's have a reviewer list somewhere with a certain format: such as C++, > Gluon, Scala/Java based on language or some other category. etc. In the > future, label bot would automatically assign reviewers based on this kind > of documentation. > > Thanks, > Qing > > =EF=BB=BFOn 10/21/18, 11:44 PM, "YiZhi Liu" wrote: > > +1 > I also suggest add reviewer list link to the PR template, so that > developers can easily request review from those reviewers. > On Sun, Oct 21, 2018 at 8:30 PM Tianqi Chen wrote= : > > > > I was suggesting something more concrete: > > > > - Add a Reviewers section to > > > https://github.com/apache/incubator-mxnet/blob/master/CONTRIBUTORS.md to > > list a list of Reviewers. > > - This is a "pesudo role", but holds weight as committers shoul= d > highly > > value their reviews during the PR process. > > - The committers/PMC could actively look for good contributors and > nominate > > them as Reviewer. > > - Contributors are encouraged to seek reviews from the list of > reviewers. > > - The committers should actively solicit code reviews from the > reviewers > > when reviewing PRs and take their reviews into serious consideratio= n. > > > > - PMCs should actively look for new committers in the current > Reviewers > > - Notably, the history reviews plus contribution likely will > provide a > > good indication on whether the person can uphold the quality > standard of > > the codebase, and provide helpful feedbacks(which is the trait that > needed > > from committer to merge code) > > > > Tianqi > > > > > > On Sun, Oct 21, 2018 at 5:13 PM Steffen Rochel < > steffenrochel@gmail.com> > > wrote: > > > > > +1 > > > With the release announcement for MXNet 1.3 all contributors incl= . > code > > > reviewers have been recognized. I suggest all future release > announcements > > > should include such recognition. Are you suggesting to highlight > most > > > active reviewers in release announcement or regularly (e.g. > monthly), > > > specifically from non-committers? > > > > > > On Sun, Oct 21, 2018 at 10:11 AM Tianqi Chen > wrote: > > > > > > > Also re another email-thread(I sent out one with my > institutional email > > > > which get blocked initially, so this one was a bit duplication > of that). > > > I > > > > think it should really be the job of committers to recognize > potential > > > > reviewers, github also makes it easier to do so, e.g. > > > > > > > > > > > > https://github.com/apache/incubator-mxnet/pulls?utf8=3D%E2%9C%93&q=3Drevi= ewed-by%3Apiiswrong > > > > > > > > Tianqi > > > > > > > > On Fri, Oct 19, 2018 at 12:05 PM Carin Meier < > carinmeier@gmail.com> > > > wrote: > > > > > > > > > +1 Great idea. Adding a name to the contributor list is a goo= d > idea. > > > > Also, > > > > > I've found that thanking the person for the review on the PR > is another > > > > way > > > > > to express gratitude for their time and effort. > > > > > > > > > > On Fri, Oct 19, 2018 at 2:51 PM Tianqi Chen > wrote: > > > > > > > > > > > Dear MXNet Community: > > > > > > > > > > > > There is a great discussion going on in terms of lowering > the barrier > > > > of > > > > > > entries and encourage more contribution to the project. On= e > of the > > > > > general > > > > > > goals is to encourage a broader pool of contributions. I > want to make > > > > the > > > > > > following proposal: > > > > > > > > > > > > Besides Committers and PMC, let us also recognize Reviewers > in the > > > > > > community. This is a "pseudo role" as there is no such > official role > > > > in > > > > > > Apache. But I want to explore the possibility of recognizin= g > active > > > > > > reviewers for example, by adding a list of names in the > contributor > > > > list. > > > > > > In general, I find it is really helpful to have more code > reviews. > > > > > > Recognizing good reviewers early enables us to find committ= er > > > > candidates, > > > > > > and encourage them to contribute and understand what is the > bar of > > > code > > > > > > quality that is required to merge the code. > > > > > > > > > > > > This can provide the community with more evidence when > recruiting new > > > > > > committers. After all the write access of committership is > about to > > > the > > > > > > code and understand the consequence of the responsibility -= - > which is > > > > > > usually can be found in high-quality review history. > > > > > > > > > > > > Please let me know what you think. > > > > > > > > > > > > Tianqi > > > > > > > > > > > > > > > > > > > > > > -- > Yizhi Liu > DMLC member > Amazon Web Services > Vancouver, Canada > > > --000000000000920f4c0578d6d308--