mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carin Meier <carinme...@gmail.com>
Subject Which merge option to use on the Import Julia binding PR?
Date Wed, 26 Sep 2018 22:41:08 GMT
The Import Julia binding PR ,(
https://github.com/apache/incubator-mxnet/pull/10149), is getting very
close to being merged. Because of the large number of commits there was a
suggestion not to use the usual "Squash and Merge".  The only option would
be "Rebase and Merge" since merging with a merge commit is not enabled for
the project.

*Squash and Merge* - The commits from this branch will be combined into one
commit in the base branch (With all the commit messages combined)

*Rebase and Merge* - The commits from this branch will be rebased and added
to the base branch

The PR is over 250+ commits (Github won't show all of them)

Thoughts about how we should handle the merge?

Thanks,
Carin

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message