mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhao, Patric" <patric.z...@intel.com>
Subject RE: Suggestions for Design Proposal Template
Date Thu, 09 Aug 2018 05:37:54 GMT
Thanks, Naveen, totally agree with you.

`Shepherd` is poetic name and I like it :)

> -----Original Message-----
> From: Naveen Swamy [mailto:mnnaveen@gmail.com]
> Sent: Thursday, August 9, 2018 11:37 AM
> To: dev@mxnet.incubator.apache.org
> Subject: Re: Suggestions for Design Proposal Template
> 
> Hi Patric,
> 
> Design template is some preliminary work that I did and plan to propose as
> part of the PR best practice(criteria). I am still working on the PR document.
> 
> Thanks for feedback on the Design Template and you make a great point. I
> discussed a similar idea with a few contributors nearby (Steffen, Andrea, Da,
> Haibin, Kellen) about adding a Shepherd to every medium and large
> feature(what makes a medium/large feature is yet to discussed and agreed
> upon) so authors can partner with another contributor to take their PRs to
> completion. This will also expand the understanding of the code base.
> 
> Your suggestion aligns very closely to what I was thinking, I will add a section
> called `Shepherd` in the template. I would suggest we have the feedback
> happen on the cwiki document (you can double click a line to leave inline
> feedback) or on dev@ list and the author can apply the feedback to the
> design. I think the decision who would(or should) like to shepherd a feature
> should also happen on dev@ as a part of the design discussion.
> 
> Yes I agree suggestions/feedback should be timely, whether it should be 1 or
> 2 weeks can be discussed and agreed upon here.
> 
> And also thank you for writing the design documents.
> 
> I will come back with a more concrete set of proposals shortly on the dev@
> and meanwhile if others have suggestions happy to take them.
> 
> Thanks, Naveen
> 
> 
> On Wed, Aug 8, 2018 at 8:04 PM, Zhao, Patric <patric.zhao@intel.com> wrote:
> 
> > Hi MXNet owner,
> >
> > We (Intel engineers) have already wrote up several design proposals
> > and published into cwiki.
> > So, I really like this documents and it make things very clear.
> > https://cwiki.apache.org/confluence/display/MXNET/
> > Apache+MXNet+Design+Proposal+Template
> >
> > Furthermore, I suggest adding a section of "feedbacks from MXNet owner
> > (committers)".
> > It's better to assign the proposal to the committers and write up the
> > committer's name in the doc.
> > The committer owner should give a clear suggestion/decision about the
> > proposal in a time slot (maybe two weeks).
> >
> > I know this will take the extra-efforts to the committer and owners.
> > But it can make the whole project more efficient and we will have a
> > clear goal.
> >
> >
> > Thanks,
> >
> > --Patric
> >
> >
> >
> >
> >
> >
> >
> >
Mime
View raw message