mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marco de Abreu <marco.g.ab...@googlemail.com.INVALID>
Subject Re: Pylint Undefined variable/name error
Date Fri, 27 Jul 2018 07:50:24 GMT
Hi,

that's a great idea. Unfortunately, we can't enable it in CI first unless
all errors have been resolved. Otherwise, your PR is going to fail with the
exact same errors and we won't be able to merge it.

Best regards,
Marco

Vandana Kannan <vandana268@gmail.com> schrieb am Fr., 27. Juli 2018, 07:16:

> Hi All,
>
> On enabling the option "undefined-variable" in pylint (in pylintrc) and
> executing on the latest code, 52 errors show up (most of them from the
> example folder). These could lead to Python NameError at runtime. The
> errors are documented in
> https://github.com/apache/incubator-mxnet/issues/11904.
>
> Currently, this Pylint option is disabled in CI and pylint is not executed
> on the example folder.
>
> Would it be a good idea to enable the option in CI to catch these errors,
> and in the meantime, fix the backlog?
>
> Thanks,
> Vandana
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message