mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Naveen Swamy <mnnav...@gmail.com>
Subject Re: Request to join developing PR Best practice guidelines
Date Fri, 27 Jul 2018 16:21:41 GMT
Hi Hao,

It would be a standard(after agreed upon here) and expect reviewers to
enforce it.

purpose, from my earlier email- "improve PR response time, participation,
and PR quality". Since we currently do have any standard or guidelines,
currently developers are using their best judgement and in some cases(when
there is not enough details) it so happens that only the close
collaborators can review the PR.

Thanks, Naveen

On Fri, Jul 27, 2018 at 2:27 AM, Hao Jin <hjjn.amzn@gmail.com> wrote:

> Hi Naveen,
> Thanks for your lead on the initiative of improving PRs! Just curious on
> the actual usage of the "PR best practices for authors", is it going to be
> a standard the community enforce on all PRs? That is, all PRs must follow
> those best practices before they could be merged. Or is it simply a bunch
> of extra tips that we recommend all contributors to follow together with
> their best judgements? Could you please clarify the purpose of it a bit
> here? Thanks!
> Best wishes,
> Hao Jin
>
> On Thu, Jul 26, 2018 at 11:35 AM, Naveen Swamy <mnnaveen@gmail.com> wrote:
>
> > Hi All,
> >
> > As a part of my job I am looking for ways to improve PR response time,
> > participation, and PR quality. On asking a few committers/contributors
> near
> > by(Andrea, Hagay, Mu Li, Steffen) and their feedback was that some PRs do
> > not have enough details and only those who collaborate closely can review
> > the PR. This could be because developers for various reasons, they might
> > forget due to time-pressure, other priorities and the current guidelines
> > might not be(IMO) enough.
> > I would like to volunteer to enhance the existing PR Checklist created by
> > the community members, and I request members to join this effort so we
> can
> > collaborate and come up with a good set of guidelines and propose here on
> > the dev@, please reach out to me on Slack or here if you are interested
> to
> > contribute.
> >
> > Currently I am thinking of splitting this effort into
> > 1) PR Best Practices for authors.
> > 2) PR Checklist for reviewers.
> > 3) Coding Guidelines.
> >
> > Thanks, Naveen
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message