From dev-return-2990-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Mon Jun 4 10:17:45 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E93F6180636 for ; Mon, 4 Jun 2018 10:17:44 +0200 (CEST) Received: (qmail 96897 invoked by uid 500); 4 Jun 2018 08:17:44 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 96880 invoked by uid 99); 4 Jun 2018 08:17:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jun 2018 08:17:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CC1BBC1274 for ; Mon, 4 Jun 2018 08:17:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.139 X-Spam-Level: *** X-Spam-Status: No, score=3.139 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_REPLY=1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id PdJtQvfzJET8 for ; Mon, 4 Jun 2018 08:17:41 +0000 (UTC) Received: from mail-vk0-f53.google.com (mail-vk0-f53.google.com [209.85.213.53]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 35FB35F24A for ; Mon, 4 Jun 2018 08:17:41 +0000 (UTC) Received: by mail-vk0-f53.google.com with SMTP id 200-v6so17320822vkc.0 for ; Mon, 04 Jun 2018 01:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=PgKgM4HKo5xustqTV2eKxsQpJc0frc0pGEl1HbTBF9U=; b=Vmk2J1/geWl3Cqf3qbXBMiOH/2KZlwpJ5zVYw/C2dyA92uCqEVmiYGLO+5c8JoK1rW tMOHVhYp0haEINcfg2K6zSZ+YU87IWcSZWucoLjgU237NF4JFF7kANkK1kx2L9UTXL2Z lI8GOO5Jmoj2IEj4QLuYJU9iYecx5mNXjICU+kkenSZKm1X2R0gRI9YWAdrR3cYqXh8k 71B4QS9F44ZJZsZV2JA2cYbLVFyzvun5hRj2GGitfY5wi/N3u01U0qmPGLVJLSrQ3Q3t sTQgTUrHR7pav2BYNhBwAhtbS7/X2Z35o07cxVFVVmcwuOg+SiNbfU0VPSNVRAs8Q/8/ w6HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=PgKgM4HKo5xustqTV2eKxsQpJc0frc0pGEl1HbTBF9U=; b=e2HTFAUGVRRBy9pX73Ouxkj2Ewi9nOPjRhIPFzTPHaXIEj0NTKJMdu1B2XgtKavg1D zBUyq7E0BMctpewnbLULbk5FEibHM3Ies3DPlCzDDMpE7jIVGwK40/Vc2GRjV8ij0B5d DZ2yujUBUTk2a7tRvNItzkx7pgS7ojsxvqh5R9jFH2frBy352O3tOZ0M3jELWsrUddM2 th73nbW1oZM1jT6s+4qXZvC7roFhlGYIsycqSm2vyPEFwHRx99fir/lnkT+aldEjSUHF 2LDR5A5B2d6s+XJJSRwYoMhb+FCmEJ9rtWBXCgnjZzwbV/hXw2uQN1RncRKoM1M/uDWm bFmA== X-Gm-Message-State: APt69E3Z3WnolbSmYBYTUS/8cjzjJVbwq5MblempfI5deMjXAbD9OHFv cTrb5dbdy7AREApZSvA6zpEP0unuvAXGYpLSNkk= X-Google-Smtp-Source: ADUXVKJKZfvXOY1zMXcehs4x5exXzH2VXdGgbi8r/LVfXeDxv9y4yjU7UHE3VYQFd+CEQUwyEw+vNOiWOFNq83JKmog= X-Received: by 2002:a1f:184:: with SMTP id 126-v6mr8994467vkb.22.1528100255369; Mon, 04 Jun 2018 01:17:35 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9f:2e0b:0:0:0:0:0 with HTTP; Mon, 4 Jun 2018 01:17:34 -0700 (PDT) In-Reply-To: <1931028260.14545704.1528098205255@mail.yahoo.com> References: <82add2f1-38d5-6f16-3e62-131e8c3baa84@mixmax.com> <5fc87924-bdd4-bd16-2d6d-12265d3a2fb6@mixmax.com> <1931028260.14545704.1528098205255@mail.yahoo.com> From: Chen HY Date: Mon, 4 Jun 2018 09:17:34 +0100 Message-ID: Subject: Re: Make cmake default To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="000000000000e70ec9056dcc906d" --000000000000e70ec9056dcc906d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable glad to hear mxnet.js is back again. 2018-06-04 8:43 GMT+01:00 Asmus Hetzel : > +1 > > I have dealt with the make/cmake stuff when integrating lapack/cusolver. > Having a single cmake would have made things far easier. > > Asmus > > > > Am Freitag, 1. Juni 2018, 23:58:17 MESZ hat Alex Zai > Folgendes geschrieben: > > Just realized that the email lists strips aways all hyperlinks. Attached > is a > copy of my previous email with links pasted in. > > What are peoples' thought on requiring cmake when building from source? > Currently we have to maintain two independent build files (CMakeLists and > Makefile) which makes it more difficult to develop (each are 600+ lines). > Also, > our current build system (in Makefile) requires that 3rdparty dependencie= s > have > binaries present (or a Makefile to generate binaries) in the repo, which > is not > always the case. > Generating a makefile with cmake will make our Makefile very simple like > PyTorch'sMakefile (20 lines of code - > https://github.com/pytorch/pytorch/blob/master/Makefile). Also, not all > 3rdparty > dependencies have binaries or Makefiles. For 3rdparty/mkldnn we end up > calling > cmake > (https://github.com/apache/incubator-mxnet/blob/master/ > prepare_mkldnn.sh#L96) > to generate binaries (this does not violate our 'no cmake dependency' as > USE_MKLDNN is OFF by default). If we encounter any library in the future > that > requires us to generate artifacts with cmake, it would be better to make > the > switch now. Lastly, we already require cmake as a dependency forwindows' > developers > (https://www.dropbox.com/s/9sfnderg58z4j1l/Screenshot% > 202018-06-01%2013.43.08.png?dl=3D0) > so this would only affect linux / mac developers who do not have cmake > already. > I currently have a pendingPR > (https://github.com/apache/incubator-mxnet/pull/11118/) that depends on > this > change. The library does not have a Makefile or binaries present. Unlike > mkldnn, > we would want this library included by default so I cannot generate > artifacts > with cmake. The alternative would be to strip out only the relevant parts > of the > code we need from the library. I did this in a previous version of myPR > (https://github.com/apache/incubator-mxnet/compare/ > dfdfd1ad15de8bb1b899effb0860a4e834093cfc...a4267eb80488804a7f74ff01f5627c > 47dd46bd78) > but it is incredible messy. > Please let me know your thoughts. > Best, > Alex > > > > > > On Fri, Jun 1, 2018 2:51 PM, Alex Zai azai91@gmail.com wrote: > What are peoples' thought on requiring cmake when building from source? > Currently we have to maintain two independent build files (CMakeLists and > Makefile) which makes it more difficult to develop (each are 600+ lines). > Also, > our current build system (in Makefile) requires that 3rdparty dependencie= s > have > binaries present (or a Makefile to generate binaries) in the repo, which > is not > always the case. > Generating a makefile with cmake will make our Makefile very simple like > PyTorch's Makefile (20 lines of code). Also, not all 3rdparty dependencie= s > have > binaries or Makefiles. For 3rdparty/mkldnn we end up calling cmake to > generate > binaries (this does not violate our 'no cmake dependency' as USE_MKLDNN i= s > OFF > by default). If we encounter any library in the future that requires us t= o > generate artifacts with cmake, it would be better to make the switch now. > Lastly, we already require cmake as a dependency for windows' > developers so this > would only affect linux / mac developers who do not have cmake already. > I currently have a pending PR that depends on this change. The library > does not > have a Makefile or binaries present. Unlike mkldnn, we would want this > library > included by default so I cannot generate artifacts with cmake. The > alternative > would be to strip out only the relevant parts of the code we need from th= e > library. I did this in a previous version of my PR but it is incredible > messy. > Please let me know your thoughts. > Best, > Alex > --=20 Chen Hanyang =E9=99=88=E6=B6=B5=E6=B4=8B Software School Fudan University +86-138-1881-7745 --000000000000e70ec9056dcc906d--