From dev-return-3057-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Thu Jun 7 23:27:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F200A180663 for ; Thu, 7 Jun 2018 23:27:52 +0200 (CEST) Received: (qmail 28649 invoked by uid 500); 7 Jun 2018 21:27:52 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 28637 invoked by uid 99); 7 Jun 2018 21:27:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2018 21:27:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EE01AC65BB for ; Thu, 7 Jun 2018 21:27:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.869 X-Spam-Level: * X-Spam-Status: No, score=1.869 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id o2XY_wva0ewG for ; Thu, 7 Jun 2018 21:27:47 +0000 (UTC) Received: from mail-oi0-f53.google.com (mail-oi0-f53.google.com [209.85.218.53]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 325EC5F357 for ; Thu, 7 Jun 2018 21:27:47 +0000 (UTC) Received: by mail-oi0-f53.google.com with SMTP id d5-v6so9983050oib.5 for ; Thu, 07 Jun 2018 14:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LOpJjRFaN+Blw7f9KjldwswvOj4m6M6vvR2PLOwvhZ4=; b=g2uxz5BqumDrisE1FEMLm+HlJ229jTQQ+8LZNTqApjvcNeqT9wJVO4gBdZVwXB6ctn p0SjvQCG53fh2cWaC84gxPQ3mQyBHUXARMd+DfxdVcDEknKt+huw2cW4SQnfyYlOcsyk PRl44y/kVPDG3Jyuf0ajnLbEELaIxIj2NmynlZU3yZLbmlDCnvibCcaPnUKQnRlmJZnn kNrtjgq036LgE2hYrs7SB/C/UcN6KinD18Z+NFt866r8BTS6Ivrt54ltPLNgOQImyoNA E/N1JJWugXpsPF7JEAJiatbRzJS+5sbIVQkKjBEX56qWkGliiGuPDSeUqpdpSe4TM4T8 U0oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LOpJjRFaN+Blw7f9KjldwswvOj4m6M6vvR2PLOwvhZ4=; b=jJ6NuV5SzVyF44RPMcQsOW/Bg6TUbY9f/YNIqpBSawFVeGdx375On4rW7beyP2nJhy JdzVjsBMr2pG6iaxIeWz4bXe09QMZVyVrx2cjF60gUSUJ4s9jAuv3JyaEmQQ8VoQ5D7f PIKGplTtvCmP5JhKXF5iuIhjgvjyU04QuHyAIIIB7xJeqOUjdk1E6miXDRlcmalP84l4 FkKTz/ZNtPnNJK0o3WIl57tCZ/6QxtZB6PsOyaxiP6lMJXuU1wsAmbNLxJQ76EdZbXgF PT+4mtHHeZvpN0627qJIuwg3+B2DbX6z5deioiaT6/kWsIWnhDSG3oIYcsv8aGrMWUCA QPlQ== X-Gm-Message-State: APt69E0pWYd5S3b4WnwSCU12z6YKqY4eR7BAf7QxSFwW0msDD89PZtRJ xfriqas6H//n8UMbOoeoZcvDb0Ph4UsztR9kEPoA/A== X-Google-Smtp-Source: ADUXVKKjJAEGVerx6kH/wVDOqNgTdbuTOIzV2QgQpcsVKYgKr0/plf5WMEJmkU+/+UknpJ+1VAg7eo1+WOdGdt5iWwo= X-Received: by 2002:aca:6884:: with SMTP id o4-v6mr1959121oik.267.1528406866487; Thu, 07 Jun 2018 14:27:46 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aca:fdcb:0:0:0:0:0 with HTTP; Thu, 7 Jun 2018 14:27:06 -0700 (PDT) In-Reply-To: <7EE05B097135E4438AAC805EE2C744E9039FE35D@SHSMSX104.ccr.corp.intel.com> References: <9C459BBE-EC89-465F-B7F3-AA4F90DED202@amazon.com> <7EE05B097135E4438AAC805EE2C744E9039FE35D@SHSMSX104.ccr.corp.intel.com> From: Naveen Swamy Date: Thu, 7 Jun 2018 14:27:06 -0700 Message-ID: Subject: Re: Regarding 1.2.1 patch release To: dev@mxnet.incubator.apache.org Cc: "Zheng, Da" , "Emani, Ashok" , "Zhao, Patric" , "Zai, Alexander" Content-Type: multipart/alternative; boundary="000000000000596fe3056e13f4b7" --000000000000596fe3056e13f4b7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Anirudh, I would like to get the fixes that was made to publish to Maven into 1.2.1 -- currently in PR https://github.com/apache/incubator-mxnet/pull/11147/ Also additionally, I would like to get the fix for https://github.com/apache/incubator-mxnet/issues/10436 - currently another contributor Andrew is working on it. -Naveen On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A wrote: > Thanks for bringing this up, Da! > > It would be great if we can have these fixes into 1.2.1 patch release, > especially for https://github.com/apache/incubator-mxnet/pull/10651, it > has fixed https://github.com/apache/incubator-mxnet/issues/11028 . > > What I want to add are: > 1. https://github.com/apache/incubator-mxnet/pull/10810 which fixed > https://github.com/apache/incubator-mxnet/issues/10809 . > 2. https://github.com/apache/incubator-mxnet/pull/10613 for doc > improvement. > > I don't quite understand the criteria for choosing patch PRs and what's > the timeline of 1.2.1 patch release. If it's possible, I also want to hav= e > below PRs. But it depends the progress of review and merging. > 1. bug fix: https://github.com/apache/incubator-mxnet/pull/11095 (under > review) > 2. perf improvement: https://github.com/apache/incubator-mxnet/pull/11047 > (approved) > 3. doc improvement: https://github.com/apache/incubator-mxnet/pull/11049 > (under review) > > BR, > -tao > > -----Original Message----- > From: Zheng, Da [mailto:dzzhen@amazon.com] > Sent: Thursday, June 7, 2018 8:55 AM > To: dev@mxnet.incubator.apache.org > Cc: Emani, Ashok ; Lv, Tao A ; > Zhao, Patric ; Zai, Alexander > Subject: Re: Regarding 1.2.1 patch release > > Hello Anirudh, > > Could you merge the bugs below? Each of the bug fixes below come with a > set of tests and many of them are critical for Gluon. > MKLDNN: > https://github.com/apache/incubator-mxnet/pull/10979 > https://github.com/apache/incubator-mxnet/pull/10731 > https://github.com/apache/incubator-mxnet/pull/10706 > https://github.com/apache/incubator-mxnet/pull/10651 > https://github.com/apache/incubator-mxnet/pull/10624 > https://github.com/apache/incubator-mxnet/pull/10619 > https://github.com/apache/incubator-mxnet/pull/10616 > > Others: > https://github.com/apache/incubator-mxnet/pull/10918 > > @Ashok @Tao @Patric @Alex, do you have other important MKLDNN bug fixes > that should be merged? > > Best, > Da > > =EF=BB=BFOn 6/6/18, 5:23 PM, "Anirudh" anirudh2290@gmail.com>> wrote: > > Hi, > > I wanted to bring up some MKLDNN fixes that went into master but not > into > 1.2. > Should these changes be going to the patch release ? We had kept some > changes from going into 1.2 branch since we were waiting for the test > suite > for MKLDNN. > Is this test suite planned for the next major or minor release? Also, > are > there any critical MKLDNN bug fixes which are in master and well > tested and > can go into the patch release ? > > Anirudh > > > On Wed, Jun 6, 2018 at 1:48 PM, Anirudh anirudh2290@gmail.com>> wrote: > > > Hi all, > > > > As you may be aware, 1.2 has an undocumented backwards incompatible > change > > relating to saving and loading params. Please see: > https://github.com/ > > apache/incubator-mxnet/issues/11091. > > > > More details about the fix will be tracked here: > https://issues.apache. > > org/jira/browse/MXNET-518 > > > > The above fix will go as part of the 1.2.1 patch release which will > be > > coming out soon. > > > > In addition to this, we will also be including: https://github.com/ > > apache/incubator-mxnet/pull/11142 > > > > I request the community to point out other bug fixes that are > critical and > > should go as part of 1.2.1 patch release. > > > > Anirudh > > > > > > --000000000000596fe3056e13f4b7--