From dev-return-3189-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Wed Jun 13 20:30:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CB5FC180609 for ; Wed, 13 Jun 2018 20:30:13 +0200 (CEST) Received: (qmail 64786 invoked by uid 500); 13 Jun 2018 18:30:12 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 64766 invoked by uid 99); 13 Jun 2018 18:30:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2018 18:30:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 91A1FC8B2C for ; Wed, 13 Jun 2018 18:30:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.139 X-Spam-Level: *** X-Spam-Status: No, score=3.139 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_REPLY=1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ie2bF6EMHC7m for ; Wed, 13 Jun 2018 18:30:10 +0000 (UTC) Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 1D2545F33D for ; Wed, 13 Jun 2018 18:30:10 +0000 (UTC) Received: by mail-wr0-f171.google.com with SMTP id o12-v6so3747001wrm.12 for ; Wed, 13 Jun 2018 11:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Fxx3ivjvEGNjsUaEgpHJ2XeK07lzi+8fXosy9T8+nek=; b=sn6SL4RiscDLOAqDq3kaot1hMrv0Yj+EYb77VKtpAEIoS0nHfXLSwsR0RTZMhjmlg/ 3cMOA00uOu1cT4aEQUCc4E3kb8i34S1M2RBJ+5iWH9kTh8DX++12soXr74UuoZu7d0aW MOcmcMsQP/WtckavJ+7+MIyzfOtRVtNLvzKFFZMn/KSNWTRPPpdhaKHlufO6seGfCRdV L4rrD5cOe5a5HmmZSxB4iu0mWsOGc2glcmzfqhVY0yG+KYW+sBBKFimM0isU72jfgjvs IPM/rEfYx2XhwF18w0cXQMwBVcinAUzf62Rh9tgw+kBY2m05pZ7nNUnazyGwnf2hooJ6 USJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Fxx3ivjvEGNjsUaEgpHJ2XeK07lzi+8fXosy9T8+nek=; b=D335HX2RP9vCT3ydBCJfu5Psn9omMSuaUReJt3Nx5KOXAgt7tEW4+mKy5zqBx7Uq+R FtqBR7zknuIaAPJ68ItUFvvYUMGLA6c6dPjQEn87TGJ8viLLRqCY9EDF8GwarEkRZ/p3 HScSkbD9qPolUQkh9FhqRhstAgEcFpSRkZkY6sE3VMt/mHI3g+KweuA/flViMC5VoWx7 YIqXR9UO3G+V+/fBOTROqTamqrH0bAGuGZLjJQ6QYpTmme2sHGlKTSW4jg4Qgc64eE4Z bY3Zoh+X7MympkmWW6y8aXFs8Vf78sS2TkaAw6MgnNQmqGS7Kvfuus5mQh7x10IDNZe1 at6w== X-Gm-Message-State: APt69E1p+lLzaNc1sCsW+QRMLXhuc/4+rhOyXds0rsI/gfGJpGl0PYMN jTfBvu/nfz3ne1badKzRvrpaEFPG30OoL2fiSYQLUA== X-Google-Smtp-Source: ADUXVKKCvTO4PpnUyeX1wZ5fCmsi/thMpNPOkXIeEc/2S8b5wu80hIGkt6ZL+tzRj4VvbF8MYn93CO8MbbIe5OUiRMg= X-Received: by 2002:adf:b02b:: with SMTP id f40-v6mr5276515wra.75.1528914608683; Wed, 13 Jun 2018 11:30:08 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5d:444f:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 11:30:08 -0700 (PDT) In-Reply-To: References: From: Thomas DELTEIL Date: Wed, 13 Jun 2018 11:30:08 -0700 Message-ID: Subject: Re: Feature branches for ARM and Android To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="0000000000002480a4056e8a2c4b" --0000000000002480a4056e8a2c4b Content-Type: text/plain; charset="UTF-8" Hi Pedro, Is there a problem in working off a branch in your own fork and issue a [WIP] PR ? This is a pattern I have seen a lot and personally I think it works well, since it also gives some visibility if someone is interested in looking at the progress of the work. You can add people collaborating with you as collaborator to your own fork and that way your commits will be run against the CI. Make sure to merge from apache/master and not larroy/master if you have conflicts? Not sure why you got these conflicts otherwise. All the best, Thomas 2018-06-12 23:39 GMT-07:00 Pedro Larroy : > Thanks a lot for creating these branches and proposing the idea, for the > reasons you listed. > > > We tried during this week to work with these branches with @lebeg for > Android and Arm support, for the reasons listed below these branches are > not useful for us, so you can delete them. > > 1. We don't have permissions to commit to these development branches, > 2. they show merge conflicts that have been solved locally before running > CI (?). I'm pretty sure I merged and resolved conflicts locally. 3. It > would also pollute the repository history with continuous merges to and > from these branches. I prefer to have a linear history in master so > changes, regressions and bisecting can be less painful when dealing with > issues. > > I think is important to share development and integrate small, incremental > patches towards architecture support, unfortunately these branches can't > help us at this stage. We will share our work through a different means and > without polluting the project with additional branches which are not meant > for production or general use. > > > > > On Mon, Jun 11, 2018 at 6:20 AM Marco de Abreu < > marco.g.abreu@googlemail.com> > wrote: > > > The problem with regular reviews here is that we might want to keep > > temporary code or hacks as a temporary solution before we finalize it. A > > regular review would have problems with that. > > > > The reason against a fork is the requirement of CI. Since multiple people > > are working on the same branch and we have to file PRs against each > other, > > it would cause problems if CI is only triggered after the fact. > > > > Ideally, the branch will be in a good state and wouldn't need many > chances > > to be mergeable for master. > > > > Naveen Swamy schrieb am So., 10. Juni 2018, 10:46: > > > > > I suggest you do a regular review and not a pass-through review for > these > > > branches as well. It would hard to manage a massive review at the end, > if > > > every commit to the branch goes with a proper PR, you could just merge > to > > > the master when its ready. > > > > > > If you want an experimental branch, why not just work it off of a fork? > > > > > > > > > On Thu, Jun 7, 2018 at 5:32 PM, Marco de Abreu < > > > marco.g.abreu@googlemail.com > > > > wrote: > > > > > > > Hello, > > > > > > > > we are currently revisiting our setup for ARM and Android. Since > we're > > > not > > > > in a stable state but need some way to collaborate while having > support > > > > from CI, we proposed the usage of feature branches. Thus, I have > create > > > the > > > > two branches devel-arm and devel-android into which Anton and Pedro > are > > > > going to submit their PRs. > > > > > > > > @Reviewers: It'd be great if you could assist with the reviews. > Please > > > note > > > > that the reviews for these branches can be less harsh, thus temporary > > > > solutions and commented code are totally acceptable. We will do a > final > > > > review after the acceptance criteria (successful cross-compilation > and > > > > manual test execution on a physical device) are fulfilled. This is > > > > necessary because we currently have no CI coverage and would like to > > keep > > > > these changes isolated from master until we found a stable solution. > > > > > > > > Best regards, > > > > Marco > > > > > > > > > > --0000000000002480a4056e8a2c4b--