From dev-return-3405-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Tue Jun 26 06:23:45 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 66975180627 for ; Tue, 26 Jun 2018 06:23:45 +0200 (CEST) Received: (qmail 75281 invoked by uid 500); 26 Jun 2018 04:23:44 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 75269 invoked by uid 99); 26 Jun 2018 04:23:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jun 2018 04:23:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 555FB1A2DC9 for ; Tue, 26 Jun 2018 04:23:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.11 X-Spam-Level: X-Spam-Status: No, score=-0.11 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id RMHcPxpHVj1X for ; Tue, 26 Jun 2018 04:23:42 +0000 (UTC) Received: from mail-pl0-f48.google.com (mail-pl0-f48.google.com [209.85.160.48]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E3CAC5F35A for ; Tue, 26 Jun 2018 04:23:41 +0000 (UTC) Received: by mail-pl0-f48.google.com with SMTP id s24-v6so7892803plq.6 for ; Mon, 25 Jun 2018 21:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:message-id:date :references:to:in-reply-to; bh=xhIo856rb4C5/2tyjyoVjAu7LRBErsgeRQj7L7AwFOY=; b=BHAA+wQWzaBK1Wig4Al5kKeFYkLwWrLsKL/8cs7Pyy2xRMqvpAWOdw9mt7LeFZKVJG SnnbTP6mPo46ADe1/B1oROPi36IvYvX0/uI8SVPYno8iq3zLnBXxrwBTx1yZU23kf6YI SEbw9Fki+5k/8e6ElAuihcU/Ne4REZNUIJxJMOwMWipjNXnOYrtWm6fUP++j3V5sG8AD +3FeF9jyB4rgD7ySkwBca+aui+GfLPoMCGLr23MMvnNm3P9mrqJ0DH+awKIafRDd6SkC 6wC/x4FVZnahfwHFLVNheO3pd4KavnPBHl8FgD8aNJ7bDyBJNMX4ciAt1iZqd8eF6QJJ OXwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:message-id:date:references:to:in-reply-to; bh=xhIo856rb4C5/2tyjyoVjAu7LRBErsgeRQj7L7AwFOY=; b=rlwyE+c+Oq2a6uf3jEQwLxFkOHInsGPJgqusz26tkqb9jSF04Bd3MYnbaGxjtzUyix z19AjZd7pO/tzNmMJnayLSMQq007/2SMf9sMobgyO4W1EI8YSS/4aVdeubJtNxSPKc5k JeQMEallqRanh+idvpCp/nDaUWps7Mq/U7Vwh3Rk9UAluDwbXsjKU6lZ+yCzlxCz/hjD WVM9LM2TAHVEeES2mUNfYtkcYxNDTyy0Q92nj+DYPJhjV8L9KrfcFlYoT3QaTMzBTa7m 7RDhIAPPsGatbAUHsw3f6ORRX9rERm5xsgqMsZysrywOoPizstRP/ZP4u4BRdXQeS+d2 ZrWQ== X-Gm-Message-State: APt69E01kjbnXvwauB/sVzygF8MtcI4/cSE4S8vyLj+W1+ri99/X1Uq3 lRoQlIr/ixMTGHPIabdiDTMMS7XQ X-Google-Smtp-Source: ADUXVKIEGz0aEPnW5q5Q84S42xqDZHesUSmi8f5nbeQs/jHhXR6XMzLEtr07WnIHlN4t12NtRyOuTw== X-Received: by 2002:a17:902:8a87:: with SMTP id p7-v6mr14895468plo.281.1529987020919; Mon, 25 Jun 2018 21:23:40 -0700 (PDT) Received: from [192.168.145.9] (c-98-234-176-202.hsd1.ca.comcast.net. [98.234.176.202]) by smtp.gmail.com with ESMTPSA id g12-v6sm728501pfh.164.2018.06.25.21.23.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 21:23:40 -0700 (PDT) Content-Transfer-Encoding: quoted-printable From: Sheng Zha Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release) Message-Id: <55DF9A76-093F-4464-9A1C-D8059A70047C@gmail.com> Date: Mon, 25 Jun 2018 21:23:39 -0700 References: To: dev@mxnet.incubator.apache.org In-Reply-To: X-Mailer: iPhone Mail (15F79) Wouldn=E2=80=99t this break users who are on 1.2.0 and used our API correctl= y? Why do we have to revert load_params, given that it=E2=80=99s backward co= mpatible? -sz > On Jun 25, 2018, at 6:30 PM, Anirudh wrote: >=20 > Hi, >=20 > 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0. > It does not adhere exactly with semver but it had to be made, to quickly > help our customers who were using the APIs incorrectly. >=20 > Anirudh >=20 >> On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha wrote: >>=20 >> save_parameters didn't exist in 1.2.0 so its addition usually isn't >> supposed to happen in a patch release if we stick to semantic versioning.= I >> couldn't find a discussion on this exception. Did it happen? >>=20 >> Would people who used 1.2.0 to save models be able to load parameters in >> 1.2.1 using the reverted load_params? (i.e. is it backward compatible) >>=20 >> -sz >>=20 >>=20 >>> On Mon, Jun 25, 2018 at 4:07 PM, Anirudh wrote: >>>=20 >>> Hi Mu, >>>=20 >>> The warining currently printed is "save_params is deprecated. Please use= >>> save_parameters." >>> Isn't this similar to what you are suggesting ? >>>=20 >>> Anirudh >>>=20 >>>> On Mon, Jun 25, 2018 at 3:47 PM, Mu Li wrote: >>>>=20 >>>> v1.2.1 will print a deprecating warning message when calling >>>> save_params. We should tell users clearly to replace "save_params" with= >>>> "save_parameters" or something else. >>>>=20 >>>> On Mon, Jun 18, 2018 at 6:52 PM, Anirudh >> wrote: >>>>=20 >>>>> Hi, >>>>>=20 >>>>> This is the vote to release Apache MXNet (incubating) version 1.2.1. >>>> Voting >>>>> will start now and close Thursday June 21st 7:00 PM PDT. >>>>>=20 >>>>> Link to release candidate 1.2.1.rc0: >>>>>=20 >>>>> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0 >>>>>=20 >>>>> View this page for installation instructions: >>>>>=20 >>>>> https://mxnet.incubator.apache.org/install/index.html >>>>>=20 >>>>> (Note: The README.md points to the 1.2.1 tag and does not work at the >>>>> moment). >>>>>=20 >>>>> Please remember to test first before voting accordingly. >>>>>=20 >>>>> +1 =3D approve >>>>> +0 =3D no opinion >>>>> -1 =3D disapprove (provide reason) >>>>>=20 >>>>> Anirudh >>>>>=20 >>>>=20 >>>=20 >>=20