From dev-return-3112-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Sat Jun 9 21:28:42 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C1D31180648 for ; Sat, 9 Jun 2018 21:28:41 +0200 (CEST) Received: (qmail 38407 invoked by uid 500); 9 Jun 2018 19:28:40 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 38393 invoked by uid 99); 9 Jun 2018 19:28:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jun 2018 19:28:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B53B9180105 for ; Sat, 9 Jun 2018 19:28:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.899 X-Spam-Level: X-Spam-Status: No, score=0.899 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Vbh4OLrDJs5h for ; Sat, 9 Jun 2018 19:28:38 +0000 (UTC) Received: from mail-pl0-f53.google.com (mail-pl0-f53.google.com [209.85.160.53]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 980AE5F288 for ; Sat, 9 Jun 2018 19:28:37 +0000 (UTC) Received: by mail-pl0-f53.google.com with SMTP id 31-v6so10072112plc.4 for ; Sat, 09 Jun 2018 12:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:date:subject:message-id :references:in-reply-to:to; bh=tnC0F6HLKRJYAo98A7WegX7s9+xIiDq8V1F2d+ShEPI=; b=kjkPQU3TM0liX/asEOhvX5mtIGNBlreByU1HLVdDJ6Ufkx9uwBf+Z/ZqewVFHf7047 ivCLaQmeX1VriCGAWBxwMBLNClpKZxz1a3pLyeVhxWpbSNR3Ja6g1djOinAu/4uqhFmh v0ESDo9MjZGTxWXpIbWwSTE2rluEqKQgvby9wlRFJd7C8TgsrpFMeHDNuUrRJ2a7bGcp ZreQJbnvykhDBBTgiWaNe1vEJy3+B3BJJ4OU0q8hWwFkMPvxYV4gFL4+/V6/8/9vP5Zh MpKX9oXxHWCK17tQzy/0SUwGDBlnKeuvoGNG85VKWUWquWR1GhyLx2tUa9fdw3vKZ5Pe fr4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version:date :subject:message-id:references:in-reply-to:to; bh=tnC0F6HLKRJYAo98A7WegX7s9+xIiDq8V1F2d+ShEPI=; b=AN6wy6n38RZ8ygTVrz3+luaXD6JMXjO0LxWPOX13STdxEHNmwu1/vFEGrXOnxuJmli tPRhasfHyMIU3KWKp1HRwXwp+T4fmIBl5zOyu889e1i7HmjzE7v2lPXKXvPx6eroSCi5 RRNaGsoVTK5mv8bSd7gaScgnvdrjFl/McNwYVLW5P1nYPQVukuacZyG7YBXodbWvneOk 8zt86xM7yMdIqlGfJ0A9shSzSrcooEg8Sj7OqgRWsifDk6rRdgocLKbcR5sblr3IJNIS FhS8Jo6Tqx4n3TCkPUN+10YIG0THSf3qeB/Cq+47Vx+spPFjyOv/hhQNiDzOkH+Q8Hif 76CA== X-Gm-Message-State: APt69E0Ydqd/p43GGK7t6l3CkRX4GgdkBnZQYnaNYDhutf7yBzuOoKus fobKTLukwZI24qjM1+r6El0Qb5/x X-Google-Smtp-Source: ADUXVKIcqHnnBJ4YvyvqbD/HPbwbhxIIbicwpIfIJFCeycFXJpsarPcAzp66QPQDr2ZtpkHX48zyIA== X-Received: by 2002:a17:902:6bca:: with SMTP id m10-v6mr11941655plt.6.1528572515447; Sat, 09 Jun 2018 12:28:35 -0700 (PDT) Received: from [192.168.1.102] (c-73-158-252-27.hsd1.ca.comcast.net. [73.158.252.27]) by smtp.gmail.com with ESMTPSA id b74-v6sm85586045pfl.138.2018.06.09.12.28.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Jun 2018 12:28:34 -0700 (PDT) From: Mu Li Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (1.0) Date: Sat, 9 Jun 2018 12:28:32 -0700 Subject: Re: Accidental commits to 1.2.0 branch using Maven apache-release profile Message-Id: <53BFB89C-D77D-463E-A444-BF3A9C82F3B2@gmail.com> References: In-Reply-To: To: dev@mxnet.incubator.apache.org X-Mailer: iPad Mail (15F79) Hi Naveen, Thanks for the clarification. Is there necessary to keep these commits submi= tted by the maveen plugin in the repo? Otherwise, can we squash these commit= s and force push it to a single commit? It's good to have a stable release o= nly patched with meaningful commits.=20 Best, Mu > On Jun 7, 2018, at 2:55 PM, Marco de Abreu w= rote: >=20 > Ah yeah that's exactly what I mean :) >=20 > Naveen Swamy schrieb am Do., 7. Juni 2018, 23:54: >=20 >> May be, but I have disabled it taking any action, so I don't see a need t= o >> do it on a private fork. I am reviewing the local changes and make a PR >> after that. >>=20 >> On Thu, Jun 7, 2018 at 2:41 PM, Marco de Abreu < >> marco.g.abreu@googlemail.com >>> wrote: >>=20 >>> Hello Naveen, >>>=20 >>> thank you for addressing this. Is it possible to let the plugin point to= >> a >>> private fork so you can review it's actions manually before they are >>> written to the main repository? That way, we could just open a PR and >>> double check everything is as expected. >>>=20 >>> Thanks a lot for taking care of the Scala releases! >>>=20 >>> Best regards, >>> Marco >>>=20 >>> Naveen Swamy schrieb am Do., 7. Juni 2018, 23:27: >>>=20 >>>> Hello all, >>>>=20 >>>> I want to bring to your attention that there have been some accidental >>>> commits to the 1.2.0 branch on my behalf. This was done by the Maven >>>> apache-release plugin while I was working on building a package to >>> publish >>>> to Maven. >>>> When you use apache-release profile in your profile by default it >> updates >>>> the package version number, create a tag on the remote repo and commit >>> all >>>> the changes from local. This is how my WIP commits got into 1.2.0 which= >>> was >>>> not protected. >>>> I have disabled this capability in my current PR >>>> https://github.com/apache/incubator-mxnet/pull/11147/. This is also >>>> necessary since we need to publish on multiple >>> platforms(osx/linux-cpu/gpu) >>>>=20 >>>> -Naveen >>>>=20 >>>=20 >>=20