mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YiZhi Liu <eazhi....@gmail.com>
Subject Re: Merging Clojure PR
Date Fri, 29 Jun 2018 07:02:54 GMT
Thanks Carin for the great contribution. I just left several questions
in the PR, would you mind to take a look? Sorry for the late review.
On Thu, Jun 28, 2018 at 12:14 PM Hagay Lupesko <lupesko@gmail.com> wrote:
>
> Thanks for your contribution Carin!
> Unfortunately i can't do a proper review for Clojure, but it's great to see
> the contribution and see how it develops and grows...
>
> On Thu, Jun 28, 2018 at 11:11 AM Carin Meier <carinmeier@gmail.com> wrote:
>
> > Thanks everyone for your feedback and efforts with the Clojure package PR.
> >
> > I'm delighted to join the MXNet community and work with you all and am
> > excited to invite the Clojure community to grow with it :)
> >
> > Thanks,
> > Carin
> >
> > On Thu, Jun 28, 2018 at 1:38 PM, Pedro Larroy <
> > pedro.larroy.lists@gmail.com>
> > wrote:
> >
> > > Yes, great work Carin! I even saw your book on Clojure autographed.
> > >
> > > Pedro.
> > >
> > > On Wed, Jun 27, 2018 at 7:24 PM Naveen Swamy <mnnaveen@gmail.com> wrote:
> > >
> > > > Hi All,
> > > >
> > > > Carin (https://github.com/gigasquid) has done a worked on a Clojure
> > > MXNet
> > > > package for the Clojure community, Thank you Carin.
> > > >
> > > > I would like to merge this PR#11205  for the upcoming release 1.3. I am
> > > not
> > > > a Clojure developer and plan to just do a preliminary review for
> > > licenses,
> > > > tests, etc., and merge the code. Myself and Pedro called on help from
> > the
> > > > Clojure community in our day job at Amazon and also Carin's also got
> > some
> > > > peers from the Clojure community to help with the review.
> > > >
> > > > If there is a committer who would like to do a complete review, I'll be
> > > > happy to step back and let you do it otherwise this PR is going in by
> > the
> > > > end of week to make it ready for 1.3.
> > > >
> > > > https://github.com/apache/incubator-mxnet/pull/11205
> > > >
> > > > Let me know
> > > >
> > > > Thanks, Naveen
> > > >
> > >
> >



-- 
Yizhi Liu
DMLC member
Amazon Web Services
Vancouver, Canada

Mime
View raw message