mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hen <>
Subject Re: About Becoming a Committer
Date Fri, 15 Jun 2018 07:00:39 GMT
On the 'Becoming+a+Committer' guidelines, I dislike this phrase:

"When it comes to code contributions, quality is more important than

There is only one 'quality' measurement, and that is "was the code merged".
If someone makes 10 different contributions and they were all horrible and
never merged (or the merger had to write a ton of fixes/tests/additions)
then yes, that's a pretty bad sign.

If the code was merged; I don't care if it's stunning code or an inspired
design. It was merged. This isn't a technical promotion process, this is
about whether the individual has shown the commitment to be extended the
trust to manage commits.

So; -1 to quality being more important than quantity. It's not.


On Fri, Jun 8, 2018 at 1:15 PM, Sheng Zha <> wrote:

> Hi,
> There have been a couple of offline inquiries from contributors about
> becoming a committer. From those inquiries, it seems that there’s confusion
> in our community about how to become a committer, so I’d like to take this
> opportunity to clarify.
> The guideline about becoming a committer can be found at
> The
> gist of the guideline is that, like any other Apache project, MXNet
> committers are invited by existing committers based on merit. The existing
> committers look for sustained, high quality contribution and community
> involvement among project contributors. When a candidate is spotted, this
> contributor will be nominated and voted among PMC members, and if all goes
> well, this contributor will receive an invitation to join as a committer
> and PMC member.
> Note that such discussion and decision happens in private among existing
> PMC members and mentors through consensus, and information regarding what
> happened in this process will always remain private, so as to rid the
> influence of different interest groups. PMC members will not ask
> contributors for committer application, nor will they accept one. Except
> the aforementioned PMC members consensus process, any other process by any
> organization under any circumstances will not be recognized.
> I hope that you find the above clarification helpful. If you have further
> question on this topic feel free to ask.
> Sheng

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message