mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marco de Abreu <marco.g.ab...@googlemail.com>
Subject Re: Accidental commits to 1.2.0 branch using Maven apache-release profile
Date Thu, 07 Jun 2018 21:55:36 GMT
Ah yeah that's exactly what I mean :)

Naveen Swamy <mnnaveen@gmail.com> schrieb am Do., 7. Juni 2018, 23:54:

> May be, but I have disabled it taking any action, so I don't see a need to
> do it on a private fork. I am reviewing the local changes and make a PR
> after that.
>
> On Thu, Jun 7, 2018 at 2:41 PM, Marco de Abreu <
> marco.g.abreu@googlemail.com
> > wrote:
>
> > Hello Naveen,
> >
> > thank you for addressing this. Is it possible to let the plugin point to
> a
> > private fork so you can review it's actions manually before they are
> > written to the main repository? That way, we could just open a PR and
> > double check everything is as expected.
> >
> > Thanks a lot for taking care of the Scala releases!
> >
> > Best regards,
> > Marco
> >
> > Naveen Swamy <mnnaveen@gmail.com> schrieb am Do., 7. Juni 2018, 23:27:
> >
> > > Hello all,
> > >
> > > I want to bring to your attention that there have been some accidental
> > > commits to the 1.2.0 branch on my behalf. This was done by the Maven
> > > apache-release plugin while I was working on building a package to
> > publish
> > > to Maven.
> > > When you use apache-release profile in your profile by default it
> updates
> > > the package version number, create a tag on the remote repo and commit
> > all
> > > the changes from local. This is how my WIP commits got into 1.2.0 which
> > was
> > > not protected.
> > > I have disabled this capability in my current PR
> > > https://github.com/apache/incubator-mxnet/pull/11147/. This is also
> > > necessary since we need to publish on multiple
> > platforms(osx/linux-cpu/gpu)
> > >
> > > -Naveen
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message