mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anirudh <anirudh2...@gmail.com>
Subject Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Date Thu, 21 Jun 2018 21:20:58 GMT
That looks like a flaky test because of atol being too small. please force
rtol and atol values and see if you are still able to reproduce.

On Thu, Jun 21, 2018 at 2:16 PM, Pedro Larroy <pedro.larroy.lists@gmail.com>
wrote:

> Observed just one failure in OSX in test_imdecode:
>
>
> ======================================================================
> FAIL: test_imdecode (test_image.TestImage)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File
> "/Users/pllarroy/devel/mxnet/mxnet_release/tests/python/
> unittest/test_image.py",
> line 94, in test_imdecode
>     assert_almost_equal(image.asnumpy(), cv_image)
>   File
> "/Users/pllarroy/devel/mxnet/mxnet_release/python/mxnet/test_utils.py",
> line 493, in assert_almost_equal
>     raise AssertionError(msg)
> AssertionError:
> Items are not equal:
> Error 980.392157 exceeds tolerance rtol=0.000010, atol=0.000000.  Location
> of maximum error:(100, 457, 1), a=103.000000, b=102.000000
>  a: array([[[  0,  10,  20],
>         [  0,  11,  19],
>         [  2,  12,  19],...
>  b: array([[[  0,  10,  20],
>         [  0,  11,  19],
>         [  2,  12,  19],...
>
> ----------------------------------------------------------------------
> Ran 505 tests in 2018.430s
>
>
> Is this one known?
>
> The other unit tests passed.
>
> On Thu, Jun 21, 2018 at 2:09 PM Haibin Lin <haibin.lin.aws@gmail.com>
> wrote:
>
> > +1
> >
> > Built from source with CUDA on Ubuntu.
> >
> > Ran example/gluon/word_language_model/train.py
> >
> > Best,
> > Haibin
> >
> >
> > On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <anirudh2290@gmail.com> wrote:
> >
> > > Hi Pedro,
> > >
> > > I think you raised this issue in 1.2.0 release here:
> > > https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
> > > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > > .
> > > I actually forgot about this issue during this release. Having said
> > that, I
> > > think since this works with make and the customers using cmake with
> > > USE_OPENMP=OFF should be considerably small we should not block the
> > release
> > > for this.
> > > The main reason we are doing this release is for this issue
> > > <https://github.com/apache/incubator-mxnet/issues/11091> . Now pulling
> > > this
> > > change for the cmake fix would be also mean we need to pull 8 more
> > commits
> > > from dmlc-core and its considerable risk to introduce for the patch
> > > release.
> > > This would also mean cutting another rc. I think in the interest of our
> > > customers who are eagerly waiting for the patch release to fix the main
> > > issue, we should move ahead here.
> > > I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1
> > release
> > > notes. I will do that now.
> > >
> > > Anirudh
> > >
> > >
> > >
> > > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > > pedro.larroy.lists@gmail.com
> > > > wrote:
> > >
> > > > I think I have fixed this before, I will check if the patch didn't
> make
> > > it
> > > > to the branch.
> > > >
> > > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > > pedro.larroy.lists@gmail.com>
> > > > wrote:
> > > >
> > > > > -1   I can't compile:
> > > > >
> > > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > ()>)::{lambda()#1}&)':
> > > > > /usr/include/c++/5/thread:137: undefined reference to
> > `pthread_create'
> > > > > collect2: error: ld returned 1 exit status
> > > > > ninja: build stopped: subcommand failed.
> > > > >
> > > > >
> > > > > No LSB modules are available.
> > > > > Distributor ID: Ubuntu
> > > > > Description:    Ubuntu 16.04.4 LTS
> > > > > Release:        16.04
> > > > > Codename:       xenial
> > > > >
> > > > >
> > > > > My build script:
> > > > >
> > > > >
> > > > > #!/bin/bash
> > > > > set -e
> > > > > set -x
> > > > >
> > > > > renice -n 19 -p $$
> > > > >
> > > > > mkdir -p build && cd build
> > > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > > -DUSE_OPENCV=ON
> > > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > > ninja -v
> > > > >
> > > > > cd ..
> > > > > if [ ! -d mxnet_py3 ]; then
> > > > >     virtualenv -p `which python3` mxnet_py3
> > > > > fi
> > > > > source mxnet_py3/bin/activate
> > > > > cd python
> > > > > pip install -e .
> > > > > cd ..
> > > > > pip install opencv-python
> > > > > pip install ipython
> > > > > pip install matplotlib
> > > > >
> > > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <indhubharathi@gmail.com>
> > wrote:
> > > > >
> > > > >> +1
> > > > >>
> > > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <anirudh2290@gmail.com>
> > wrote:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > This is the vote to release Apache MXNet (incubating) version
> > 1.2.1.
> > > > >> Voting
> > > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > >> >
> > > > >> > Link to release candidate 1.2.1.rc0:
> > > > >> >
> > > > >> > https://github.com/apache/incubator-mxnet/releases/tag/
> 1.2.1.rc0
> > > > >> >
> > > > >> > View this page for installation instructions:
> > > > >> >
> > > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > > >> >
> > > > >> > (Note: The README.md points to the 1.2.1 tag and does not
work
> at
> > > the
> > > > >> > moment).
> > > > >> >
> > > > >> > Please remember to test first before voting accordingly.
> > > > >> >
> > > > >> > +1 = approve
> > > > >> > +0 = no opinion
> > > > >> > -1 = disapprove (provide reason)
> > > > >> >
> > > > >> > Anirudh
> > > > >> >
> > > > >>
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message