mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Naveen Swamy <mnnav...@gmail.com>
Subject Re: Regarding 1.2.1 patch release
Date Thu, 07 Jun 2018 21:27:06 GMT
Hi Anirudh,

I would like to get the fixes that was made to publish to Maven into 1.2.1
-- currently in PR https://github.com/apache/incubator-mxnet/pull/11147/

Also additionally, I would like to get the fix for
https://github.com/apache/incubator-mxnet/issues/10436 - currently another
contributor Andrew is working on it.

-Naveen

On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A <tao.a.lv@intel.com> wrote:

> Thanks for bringing this up, Da!
>
> It would be great if we can have these fixes into 1.2.1 patch release,
> especially for https://github.com/apache/incubator-mxnet/pull/10651, it
> has fixed https://github.com/apache/incubator-mxnet/issues/11028 .
>
> What I want to add are:
> 1. https://github.com/apache/incubator-mxnet/pull/10810 which fixed
> https://github.com/apache/incubator-mxnet/issues/10809 .
> 2. https://github.com/apache/incubator-mxnet/pull/10613 for doc
> improvement.
>
> I don't quite understand the criteria for choosing patch PRs and what's
> the timeline of 1.2.1 patch release. If it's possible, I also want to have
> below PRs. But it depends the progress of review and merging.
> 1. bug fix: https://github.com/apache/incubator-mxnet/pull/11095 (under
> review)
> 2. perf improvement: https://github.com/apache/incubator-mxnet/pull/11047
> (approved)
> 3. doc improvement: https://github.com/apache/incubator-mxnet/pull/11049
> (under review)
>
> BR,
> -tao
>
> -----Original Message-----
> From: Zheng, Da [mailto:dzzhen@amazon.com]
> Sent: Thursday, June 7, 2018 8:55 AM
> To: dev@mxnet.incubator.apache.org
> Cc: Emani, Ashok <ashok.emani@intel.com>; Lv, Tao A <tao.a.lv@intel.com>;
> Zhao, Patric <patric.zhao@intel.com>; Zai, Alexander <alexzai@amazon.com>
> Subject: Re: Regarding 1.2.1 patch release
>
> Hello Anirudh,
>
> Could you merge the bugs below? Each of the bug fixes below come with a
> set of tests and many of them are critical for Gluon.
> MKLDNN:
> https://github.com/apache/incubator-mxnet/pull/10979
> https://github.com/apache/incubator-mxnet/pull/10731
> https://github.com/apache/incubator-mxnet/pull/10706
> https://github.com/apache/incubator-mxnet/pull/10651
> https://github.com/apache/incubator-mxnet/pull/10624
> https://github.com/apache/incubator-mxnet/pull/10619
> https://github.com/apache/incubator-mxnet/pull/10616
>
> Others:
> https://github.com/apache/incubator-mxnet/pull/10918
>
> @Ashok @Tao @Patric @Alex, do you have other important MKLDNN bug fixes
> that should be merged?
>
> Best,
> Da
>
> ´╗┐On 6/6/18, 5:23 PM, "Anirudh" <anirudh2290@gmail.com<mailto:
> anirudh2290@gmail.com>> wrote:
>
>     Hi,
>
>     I wanted to bring up some MKLDNN fixes that went into master but not
> into
>     1.2.
>     Should these changes be going to the patch release ? We had kept some
>     changes from going into 1.2 branch since we were waiting for the test
> suite
>     for MKLDNN.
>     Is this test suite planned for the next major or minor release? Also,
> are
>     there any critical MKLDNN bug fixes which are in master and well
> tested and
>     can go into the patch release ?
>
>     Anirudh
>
>
>     On Wed, Jun 6, 2018 at 1:48 PM, Anirudh <anirudh2290@gmail.com<mailto:
> anirudh2290@gmail.com>> wrote:
>
>     > Hi all,
>     >
>     > As you may be aware, 1.2 has an undocumented backwards incompatible
> change
>     > relating to saving and loading params. Please see:
> https://github.com/
>     > apache/incubator-mxnet/issues/11091.
>     >
>     > More details about the fix will be tracked here:
> https://issues.apache.
>     > org/jira/browse/MXNET-518
>     >
>     > The above fix will go as part of the 1.2.1 patch release which will
> be
>     > coming out soon.
>     >
>     > In addition to this, we will also be including: https://github.com/
>     > apache/incubator-mxnet/pull/11142
>     >
>     > I request the community to point out other bug fixes that are
> critical and
>     > should go as part of 1.2.1 patch release.
>     >
>     > Anirudh
>     >
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message