mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zheng, Da" <dzz...@amazon.com.INVALID>
Subject Re: Reverting pull request
Date Fri, 15 Jun 2018 21:23:20 GMT
+1 The PR has been merged a while ago, so it has been tested by many people.
Other people's work now depends on this PR. Reverting it at this point can cause a lot of
problems for many other people.

Best,
Da

´╗┐On 6/15/18, 2:18 PM, "workcrow@gmail.com on behalf of Tianqi Chen" <workcrow@gmail.com
on behalf of tqchen@cs.washington.edu> wrote:

    +1   We would be stuck at local minimums if we just keep reverting the PR
    that brings improvements in the long term
    
    Tianqi
    
    On Fri, Jun 15, 2018 at 2:15 PM, Mu Li <muli.cmu@gmail.com> wrote:
    
    > Why reverting instead of fixing the bugs? Static memory aims to reduce
    > memory allocation, it's a key feature to bridge the perf gap between gluon
    > and symbol.
    >
    > On Fri, Jun 15, 2018 at 2:06 PM, Marco de Abreu <
    > marco.g.abreu@googlemail.com.invalid> wrote:
    >
    > > Hello,
    > >
    > > I'm reverting https://github.com/apache/incubator-mxnet/pull/10817 as of
    > > https://github.com/apache/incubator-mxnet/pull/11311 due to regressions
    > > described in https://github.com/apache/incubator-mxnet/issues/11171 and
    > > https://github.com/apache/incubator-mxnet/pull/10817.
    > >
    > > The pull request has been self-merged without proper review and
    > introduced
    > > regressions. Committers should act as role models in this project and
    > > adhere to software engineer best practices.
    > >
    > > Best regards,
    > > Marco
    > >
    >
    

Mime
View raw message