From dev-return-2251-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Tue Feb 27 23:23:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6DD1B180651 for ; Tue, 27 Feb 2018 23:23:38 +0100 (CET) Received: (qmail 66698 invoked by uid 500); 27 Feb 2018 22:23:37 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 66682 invoked by uid 99); 27 Feb 2018 22:23:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2018 22:23:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3FF18C106C for ; Tue, 27 Feb 2018 22:23:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.879 X-Spam-Level: ** X-Spam-Status: No, score=2.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_REPLY=1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id HsO3NTt8NVUl for ; Tue, 27 Feb 2018 22:23:33 +0000 (UTC) Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 0A0925F175 for ; Tue, 27 Feb 2018 22:23:33 +0000 (UTC) Received: by mail-wm0-f51.google.com with SMTP id i3so99456wmi.4 for ; Tue, 27 Feb 2018 14:23:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=q5ecO8C8fiE/+lf09cbRqITU+E3LrZcg76xpj1BwxEk=; b=Pp2UccIpG5CRAbQ+Hl+wuZT/DnfbbG8obg2Jgn5VdYo9/6G8xCuFNrebZspZhilYxw veJ3UH1WAUBRRTV7g6u18HLqwbYEq9jsieRUBA90IR4EVemH5M9jQjU5FY6ETTmFV+5A vl7eW9F43HQbHBDJenxHQxX3WN0yKQhnnc+DweMzS/0sg9FBjPyLJdO/0pQ1Q/r7KG44 d6/fRbdkFw/UG6TBkgS9vFknQOMb8Dk6Qc1pgvzwjseQALVKqHQLyPpOX1yALbE2PO2l /HCTmuw52i4BLcV/aGXnAI/LaPLcUpogMqFAG1tfLieQvacq4PJtjJekJgH9wmqdcU8N N2oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=q5ecO8C8fiE/+lf09cbRqITU+E3LrZcg76xpj1BwxEk=; b=MvMMsMYM/Ji+WPit5mrzVrNgWpTvgtyF6fLRc4LBQTbdZg31dBKRvA27UZNaE0D8Ov bLlVIGNWIu+3aDyVYs9HYXF78D8Wv0mX9IaTPqnjjKmBXs82uPxpYeExGdDoptr7ziuq rdw/7swaq736YfvKyaw/Z8VPVhl+qAWexIMpIxSecaF4dkyqrVkYlwsPCvlaWMF0V5ux 75JHcEaz6/2yt4CIRxrLsu9K5HR1HBw1yTjsxZvYcZ02gc130fzLvv7Dxxf8S2fxKBXm SJ2q6s10kvvbUMgfCQCFDjrXJtQuUwd8XsGrjTH0FeIHa+y+E7zPUaYuSESWSJ58FHiP PoRQ== X-Gm-Message-State: APf1xPDi7Y01Yxy8FLCdsuZJc309BniGmRTdoJijvNalSo0EyjcvJtC8 2AA1j5Ptds5vyX6hFoUt+uPurZMqbBGZUTVthimK2g== X-Google-Smtp-Source: AH8x227refz7aQbLHuvGgvbI6JdNvQzhbzV/jFeDmIBv8VI3AqhRc/I37oA1w0RJ38LqMZXRqaq/srcCPYK14PhYf3Y= X-Received: by 10.80.203.134 with SMTP id k6mr20436587edi.166.1519770212281; Tue, 27 Feb 2018 14:23:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.220.129 with HTTP; Tue, 27 Feb 2018 14:23:31 -0800 (PST) In-Reply-To: References: From: Nan Zhu Date: Tue, 27 Feb 2018 14:23:31 -0800 Message-ID: Subject: Re: [VOTE] tracking code changes with JIRA by associating pull requests To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="f40304394a8ca4b7f405663913f2" --f40304394a8ca4b7f405663913f2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Any reason u need the [MODULE_NAME] in there It will help the reviewers to identify what are the interesting PRs to them e.g. I am interested in scala package, but https://github.com/apache/incubator-mxnet/pull/9771, even with a JIRA id, cannot help me to identify it's a scala part change I may be interested in > What ??? elaborate please?? we do not need additional engineering efforts to implement sync the only thing is to get this vote passed, and all committers do not merge the PRs unless there is a JIRA (except the situations in 2) On Tue, Feb 27, 2018 at 2:13 PM, Suneel Marthi wrote: > On Tue, Feb 27, 2018 at 10:50 PM, Nan Zhu wrote: > > > Thanks, Suneel! > > > > the vote still remains sense on its major points > > > > " > > 1. most of PRs should be titled as [MXNET-???][MODULE_NAME] PR short > > description, where MXNET-??? is the JIRA ID, MODULE_NAME can be python, > > scala, symbol, etc. > > > > Any reason u need the [MODULE_NAME] in there - I would -1 that > > [MXNET-XYZ] is unique enuf to identify the specific module - not to menti= on > that the different modules can be setup to label each jira - so > [MODULE-blah] is unnecessary. > > > > 2. only the very tiny fix, e.g. fix a typo, remove some unused variable= s, > > or the hotfix which brings the broken build back to track, can be filed > > without JIRA ID in title, > > > > Agreed - and in this case the convention has been to use [NO-JIRA] in > title. > > > " > > > > though we do not need additional efforts to make it happen, > > > > the only thing we need to get a consensus on is that, we need to use JI= RA > > to track work items and title PRs with JIRA ids > > > > What ??? elaborate please?? > > > > > Hi, all, a friendly reminder, the vote will be ended at 12:00 p.m. on > this > > Friday > > > > > > Best, > > > > Nan > > > > > > > > On Tue, Feb 27, 2018 at 1:44 PM, Suneel Marthi > wrote: > > > > > Suggest you see how other projects are doing it - Flink, Kafka or any > > other > > > project. > > > > > > Yes u r right. > > > > > > When u make a github PR with PR label in title like [Flink-3456] for > eg: > > - > > > that way the corresponding JIRA - Flink-3456 here would be > automatically > > > updated. > > > > > > On Tue, Feb 27, 2018 at 10:28 PM, Nan Zhu > > wrote: > > > > > > > Hi, Suneel, > > > > > > > > how can we enable it? when we titled JIRA id in pull request, it wi= ll > > > > synchronized automatically? > > > > > > > > Best, > > > > > > > > Nan > > > > > > > > On Tue, Feb 27, 2018 at 1:23 PM, Suneel Marthi > > > wrote: > > > > > > > > > All projects on Apache have Jira <---> Github integration in plac= e. > > > > > > > > > > So its a solved problem - look at Flink, Kafka, Mahout, OpenNLP, > > > > > PredictionIO and every other Apache project - all of them have th= is > > > > > working. > > > > > > > > > > > > > > > > > > > > On Tue, Feb 27, 2018 at 8:35 PM, Steffen Rochel < > > > steffenrochel@gmail.com > > > > > > > > > > wrote: > > > > > > > > > > > Nan - have you looked at plugin's to make the integration and > > > > > > synchronization between Jira and github easier? E.g. > > > > > > https://www.atlassian.com/blog/jira-software/connecting- > > > > jira-6-2-github > > > > > f > > > > > > Ideally one has one button in github to create a Jira and > > afterwards > > > > > > changes on either github or Jira get synchronized. > > > > > > What tools is ASF infra recommending? > > > > > > Have you used > > > > > > https://github.com/apache/spark/blob/master/dev/github_jira_ > > sync.py > > > > and > > > > > > what is the recommended use case? How do get github issues > updated > > > from > > > > > > Jira? > > > > > > > > > > > > Steffen > > > > > > > > > > > > On Tue, Feb 27, 2018 at 10:31 AM Indhu > > > > wrote: > > > > > > > > > > > > > +1 to the proposal > > > > > > > > > > > > > > > > > > > > > On Tue, Feb 27, 2018, 9:20 AM Nan Zhu > > > > wrote: > > > > > > > > > > > > > > > ideally, > > > > > > > > > > > > > > > > users report something fishy in github issue > > > > > > > > > > > > > > > > when confirmed that it is a bug or something to be improved= , > we > > > > > should > > > > > > > > create JIRAs > > > > > > > > > > > > > > > > On Sun, Feb 25, 2018 at 9:31 AM, Chris Olivier < > > > > > cjolivier01@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > i believe that JIRAs are =E2=80=9Cwork items@, while gith= ub issues > > are > > > > > more > > > > > > > like > > > > > > > > > reporting. at least this is what Infra sort of claimed. > > > > > > > > > > > > > > > > > > On Sun, Feb 25, 2018 at 9:30 AM Chris Olivier < > > > > > cjolivier01@gmail.com > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Feb 23, 2018 at 9:56 AM Marco de Abreu < > > > > > > > > > > marco.g.abreu@googlemail.com> wrote: > > > > > > > > > > > > > > > > > > > >> Hello Nan, > > > > > > > > > >> > > > > > > > > > >> Good suggestion! > > > > > > > > > >> > > > > > > > > > >> "hotfix which brings the broken build back to track" > > > > nitpicking, > > > > > > > but I > > > > > > > > > >> wouldn't consider this a tiny fix. There should also b= e > a > > > jira > > > > > > that > > > > > > > > > >> reported the build being broken, so that shouldn't be = a > > > > problem > > > > > to > > > > > > > > link. > > > > > > > > > >> > > > > > > > > > >> Very good idea with the automated script! > > > > > > > > > >> > > > > > > > > > >> How would we handle permissions? Which actions are > > > > > non-committers > > > > > > > able > > > > > > > > > to > > > > > > > > > >> execute and in which cases would a committer be > required? > > > > > > > > > >> > > > > > > > > > >> How would we treat GitHub issues in future? As a board > for > > > > users > > > > > > to > > > > > > > > ask > > > > > > > > > >> usage questions? > > > > > > > > > >> > > > > > > > > > >> In order to improve user experience for new developers= , > > I'd > > > > like > > > > > > to > > > > > > > > > >> suggest > > > > > > > > > >> that more experienced people might create jira tickets > on > > > > behalf > > > > > > of > > > > > > > > > others > > > > > > > > > >> instead of telling them "please create a ticket". I > think > > we > > > > all > > > > > > > made > > > > > > > > > the > > > > > > > > > >> experience with people from it department who blocked > > every > > > > > > request > > > > > > > > > until > > > > > > > > > >> a > > > > > > > > > >> ticket was created and assigned :P > > > > > > > > > >> > > > > > > > > > >> Best regards, > > > > > > > > > >> Marco > > > > > > > > > >> > > > > > > > > > >> Am 23.02.2018 6:07 nachm. schrieb "CodingCat" < > > > > > > codingcat@apache.org > > > > > > > >: > > > > > > > > > >> > > > > > > > > > >> Hi, all > > > > > > > > > >> > > > > > > > > > >> To make the changes in code base more trackable, > > > > > > > > > >> > > > > > > > > > >> I would propose to link each PR with the a JIRA from n= ow > > on: > > > > > > > > > >> > > > > > > > > > >> 1. most of PRs should be titled as > > [MXNET-???][MODULE_NAME] > > > PR > > > > > > short > > > > > > > > > >> description, where MXNET-??? is the JIRA ID, MODULE_NA= ME > > can > > > > be > > > > > > > > python, > > > > > > > > > >> scala, symbol, etc. > > > > > > > > > >> > > > > > > > > > >> 2. only the very tiny fix, e.g. fix a typo, remove som= e > > > unused > > > > > > > > > variables, > > > > > > > > > >> or the hotfix which brings the broken build back to > track, > > > can > > > > > be > > > > > > > > filed > > > > > > > > > >> without JIRA ID in title, > > > > > > > > > >> > > > > > > > > > >> In JIRA side, to link the issue with an arrived PR, we > can > > > > run a > > > > > > > > script > > > > > > > > > >> like https://github.com/apache/ > > > spark/blob/master/dev/github_ > > > > > > > > > jira_sync.py > > > > > > > > > >> to > > > > > > > > > >> update JIRA status (can be run in Jenkins) > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> The benefits of applying such a flow include (but not > > > limited > > > > > to) > > > > > > > > > >> > > > > > > > > > >> 1. facilitate the release process: > > > > > > > > > >> > > > > > > > > > >> e.g., as long as tagging each JIRA with the correct > > affected > > > > > > version > > > > > > > > and > > > > > > > > > >> fixed version, the release manager can quickly identif= y > > what > > > > are > > > > > > the > > > > > > > > > >> changes applied in this version; or we can quickly > > identify > > > > > > whether > > > > > > > > > there > > > > > > > > > >> is any blocker issue in the JIRA > > > > > > > > > >> > > > > > > > > > >> 2. trackable changes > > > > > > > > > >> > > > > > > > > > >> any changes in MXNET can be quickly searched through > JIRA > > or > > > > > even > > > > > > > > > through > > > > > > > > > >> Google (JIRA looks like did something makes it more > > > indexable > > > > by > > > > > > > > > Google), > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> If the vote gets pass, the plan in the near horizon > > > includes > > > > > > > > > >> > > > > > > > > > >> 1. update JIRA with the modules names > > > > > > > > > >> > > > > > > > > > >> 2. write runbook for release manager/committer for > > releasing > > > > new > > > > > > > > > >> version/merging patches, as well as contributors about > the > > > > usage > > > > > > of > > > > > > > > JIRA > > > > > > > > > >> > > > > > > > > > >> 3. push the changes to the existing and coming PRs (th= is > > > also > > > > > > needs > > > > > > > > the > > > > > > > > > >> collaboration across the whole committer team) > > > > > > > > > >> > > > > > > > > > >> The vote will end at 12:00 p.m. of March 2nd, 2018 > > > > > > > > > >> > > > > > > > > > >> Best, > > > > > > > > > >> > > > > > > > > > >> Nan > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --f40304394a8ca4b7f405663913f2--