From dev-return-2090-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Fri Feb 2 02:07:48 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A2BBE180652 for ; Fri, 2 Feb 2018 02:07:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 928F9160C56; Fri, 2 Feb 2018 01:07:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DB517160C44 for ; Fri, 2 Feb 2018 02:07:47 +0100 (CET) Received: (qmail 13426 invoked by uid 500); 2 Feb 2018 01:07:47 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 13408 invoked by uid 99); 2 Feb 2018 01:07:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Feb 2018 01:07:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DBD1EC03A7 for ; Fri, 2 Feb 2018 01:07:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.879 X-Spam-Level: * X-Spam-Status: No, score=1.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id paFW0qP0TnOk for ; Fri, 2 Feb 2018 01:07:45 +0000 (UTC) Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8E6695F2C3 for ; Fri, 2 Feb 2018 01:07:44 +0000 (UTC) Received: by mail-lf0-f45.google.com with SMTP id q17so29023438lfa.9 for ; Thu, 01 Feb 2018 17:07:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=96tFOfP6IDohxCNp10T4BtoX5nIYmhu5cT4SUhVmXvg=; b=gRhK0MPVpKRad8bsnTv1xKbGrhEWtfz+B+AB/vJhZEWTqtwevG1lxsCNsmQuAY40a+ zPafCRubYx1dIiLuLqqAB/g9FwNqOloiR+a/WvAi0jX/25RmMvvcXbnsT71ZSV1957xn aHXBLLKaWzm/eGeeSJIEkWIUbWaEoczBXZh9fzebSM/5WcAUl0ii/mkvcIxiqYDy3F06 tq10sXylI1zZlRpiuza2nwWejcX6jWbsdWN+Ugdj/PTdDux224zoGksjPz6dcsTfLXU/ LrCRFNA9MdeTvjL6mk3BXM3HrUV7sEwIxNRHvFwD0eVykPhrxDByJTKfEPGbFzQB41j7 Wf6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=96tFOfP6IDohxCNp10T4BtoX5nIYmhu5cT4SUhVmXvg=; b=eh8j1xjoaatXW10Mom1Mc3oxCt0DHuMdvIj+/ptpfpzuCOX7hbA3eSBMtLmFH2EZtz M9N6+w0KxO/PqXjQ7OttrjXnNaoAzJYIS2LEFVWbk5ppbQG1lBRufSK51xl/Pq2a8Qv8 ZRQAPRwEjLwoNT4ZKth+jS7gq4BuW67/86K41UvoZhUbzHgPhmpEDgFwSqNR1oVroaEh HIwf2y9dMwgRvxND0svl4d7GRCwWT/aWHcFlnvfsfH0tQmYXUHNYQ271nZcFdaGuzZpx Y2FJulp00sWzgTkRH/uI55izNOQUKGtlUHwK+PwSWOwJ0Qsx73IwdAjShNxnXqQRSPO1 uc/Q== X-Gm-Message-State: AKwxytd8Atc9H7XdEDBCvmWXi4V6eHIlTLmouUDu7hpcIth5tsiVvAM5 QXMJ7YaH7R0GbbhQQ7We91gdBYM2Jd7lWZdQZXk= X-Google-Smtp-Source: AH8x226caYanY5OzlU9HzGetURVp0GAIwJFXkvFylzcrxjmCMa/t2tVQnI+qn0YEjGC9Z7lIOka1PUBsUUJCplc016k= X-Received: by 10.25.178.86 with SMTP id b83mr23576176lff.111.1517533657094; Thu, 01 Feb 2018 17:07:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.169.206 with HTTP; Thu, 1 Feb 2018 17:06:56 -0800 (PST) In-Reply-To: References: From: Marco de Abreu Date: Thu, 1 Feb 2018 17:06:56 -0800 Message-ID: Subject: Re: [VOTE] When in Doubt, Wait 24 Hours Before Merging To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="f403045f4f4090dfc50564305663" --f403045f4f4090dfc50564305663 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Additionally, I'd like to propose to add that people with open requested changes actively have to be pinged and that the 24 hours only start after that ping. Was that part of your intention, Sheng? -Marco On Thu, Feb 1, 2018 at 4:29 PM, Nan Zhu wrote: > +1, but do not understand why we merged PRs which was not completely > approved? > > On Thu, Feb 1, 2018 at 4:20 PM, Sheng Zha wrote: > > > Hi, > > > > In order to avoid having miscommunication and unaligned expectation, I'= d > > like to propose a lazy vote on a new rule for merging pull requests. > > Specifically, for merging PRs, if there are open review comments and > > changes afterwards didn=E2=80=99t address the comments, we should have = a > > grace-period of 24 hours for commenters to respond to the changes. > > > > This rule should take effect on Feb. 6th if there's no objection. Thank= s. > > > > Bests, > > Sheng > > > --f403045f4f4090dfc50564305663--