mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marco de Abreu <marco.g.ab...@googlemail.com>
Subject Re: [VOTE] When in Doubt, Wait 24 Hours Before Merging
Date Fri, 02 Feb 2018 01:06:56 GMT
Additionally, I'd like to propose to add that people with open requested
changes actively have to be pinged and that the 24 hours only start after
that ping. Was that part of your intention, Sheng?

-Marco

On Thu, Feb 1, 2018 at 4:29 PM, Nan Zhu <zhunanmcgill@gmail.com> wrote:

> +1, but do not understand why we merged PRs which was not completely
> approved?
>
> On Thu, Feb 1, 2018 at 4:20 PM, Sheng Zha <zhasheng@apache.org> wrote:
>
> > Hi,
> >
> > In order to avoid having miscommunication and unaligned expectation, I'd
> > like to propose a lazy vote on a new rule for merging pull requests.
> > Specifically, for merging PRs, if there are open review comments and
> > changes afterwards didn’t address the comments, we should have a
> > grace-period of 24 hours for commenters to respond to the changes.
> >
> > This rule should take effect on Feb. 6th if there's no objection. Thanks.
> >
> > Bests,
> > Sheng
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message