mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Olivier <cjolivie...@gmail.com>
Subject Re: [VOTE] When in Doubt, Wait 24 Hours Before Merging
Date Fri, 02 Feb 2018 15:43:39 GMT
-1 (binding) based upon:  It's not clear what triggers the timer or how a
veto is preserved.

I'd like to argue that any comment on a PR by a committer should get some
sort of response, even if it is "bugger off", and the ability to veto must
be preserved (ie set review status as 'request changes')

On Fri, Feb 2, 2018 at 6:18 AM, Isabel Drost-Fromm <isabel@apache.org>
wrote:

>
>
> Am 2. Februar 2018 01:20:31 MEZ schrieb Sheng Zha <zhasheng@apache.org>:
> >Specifically, for merging PRs, if there are open review comments and
> >changes afterwards didn’t address the comments, we should have a
> >grace-period of 24 hours for commenters to respond to the changes.
>
> Typical waiting period for lazy consensus would be 72 hours IIRC so ppl in
> other timezones/ on holiday get a chance to check as well.
>
> Isabel
>
> --
> Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message