mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Olivier <>
Subject Re: [VOTE] When in Doubt, Wait 24 Hours Before Merging
Date Fri, 02 Feb 2018 01:07:31 GMT
I assume you mean after a call of "Is everything ok to merge?"

There'd have to be some sort of trigger for ppl to know someone has started
the 24-hour timer, right?

On Thu, Feb 1, 2018 at 4:20 PM, Sheng Zha <> wrote:

> Hi,
> In order to avoid having miscommunication and unaligned expectation, I'd
> like to propose a lazy vote on a new rule for merging pull requests.
> Specifically, for merging PRs, if there are open review comments and
> changes afterwards didn’t address the comments, we should have a
> grace-period of 24 hours for commenters to respond to the changes.
> This rule should take effect on Feb. 6th if there's no objection. Thanks.
> Bests,
> Sheng

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message