mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Isabel Drost-Fromm <isa...@apache.org>
Subject Re: [VOTE] When in Doubt, Wait 24 Hours Before Merging
Date Fri, 02 Feb 2018 14:18:19 GMT


Am 2. Februar 2018 01:20:31 MEZ schrieb Sheng Zha <zhasheng@apache.org>:
>Specifically, for merging PRs, if there are open review comments and
>changes afterwards didn’t address the comments, we should have a
>grace-period of 24 hours for commenters to respond to the changes.

Typical waiting period for lazy consensus would be 72 hours IIRC so ppl in other timezones/
on holiday get a chance to check as well.

Isabel

-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Mime
View raw message