From dev-return-1762-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Fri Jan 5 20:25:16 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9DC1C180647 for ; Fri, 5 Jan 2018 20:25:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8D672160C27; Fri, 5 Jan 2018 19:25:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D30DD160C15 for ; Fri, 5 Jan 2018 20:25:15 +0100 (CET) Received: (qmail 40012 invoked by uid 500); 5 Jan 2018 19:25:15 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 39999 invoked by uid 99); 5 Jan 2018 19:25:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2018 19:25:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4AAB518078F for ; Fri, 5 Jan 2018 19:25:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.879 X-Spam-Level: * X-Spam-Status: No, score=1.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id IyohOx_zK3gh for ; Fri, 5 Jan 2018 19:25:12 +0000 (UTC) Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 0B10C5F286 for ; Fri, 5 Jan 2018 19:25:12 +0000 (UTC) Received: by mail-wm0-f49.google.com with SMTP id b141so4312209wme.1 for ; Fri, 05 Jan 2018 11:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=ATAKcv4U3QJuCzbItzIlE8h1ib/pwJ1PHRGp4dYnwyA=; b=E6WX8SDzevh602vnHE+hG1BUhN9GxhbMhanwsi/ZVZM1mHMEjpJh+LIab3fNhuBaB2 7nmQ4xomrusV41Vx9BzfTstqDMGCfSIMNUZQPkO6yNxMqINEVDU411EW0UWgS1MPLqTe lyE8m6u6gMLvBZybIn6KYuyrSq0qbqyO3BP8iVrYg8Hg5sSo6NKqaQbwp9lMx3lyI08A oxcZ+LnNYn2XgOchV9tTiUXurfWQ7HVsSxqPugCW9cLSszqB0+0fT5JtHujo+ZE92X9O JBeozhN0tLtbCsGn/qlva7Mpict9R03F8tD/BDzh/n6nZnhiPq+cp8NXgOv2qXsyxg6+ H4Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=ATAKcv4U3QJuCzbItzIlE8h1ib/pwJ1PHRGp4dYnwyA=; b=SmFlCkdcxFt3jAoJP7x6yvwQx0JbFS4emHVHqyzLneirzLQN2r+Qdy1swyxwr0ND1+ zW7LyrqFugkrk065UnDybTctyHHqPeK9GukTiT2E9RoOd8Ntot5G94s1VpVH1ooQMocx hZ+9r6IkpXPd8U0FetCcvHa3erA2/f5s3MIqxtRs/yan9pbi/Z0ppooNGc7A/HxznTnh JuLbKIyk8uvIxkMpeU9rMiXG6czks3vQTKSYofGoki+K+ZQtCrTiusQ2eidtlfKkowbh i8grRG1HxfhJpMc+ABSX1VtMLLfed2HsplH6EUqeDOyONuy2OgflOioMnxVNTESN/R+k db7A== X-Gm-Message-State: AKGB3mLIQ7jFdasykb4NTcH7Zow/mI29NlmHHnXO28dYI/j2cztP8nOX i+mIBf9+2zNMXfdRsJ7wtFQRh+ElUWkweFfol58kYQ== X-Google-Smtp-Source: ACJfBos3mKTEDjtd66M5kWDhm6oPsQi7fma9XWNwAZxsOs9zlixjpoUc7mQ9VlEUrHznfFqiYsPfL3ljqLUuNvcbxuc= X-Received: by 10.80.133.33 with SMTP id 30mr5627722edr.42.1515180311425; Fri, 05 Jan 2018 11:25:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.195.1 with HTTP; Fri, 5 Jan 2018 11:25:10 -0800 (PST) In-Reply-To: References: From: Nan Zhu Date: Fri, 5 Jan 2018 11:25:10 -0800 Message-ID: Subject: Re: Increase indentation limit from 100 to 120 characters To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="f403045c8b5c3bb81b05620c68a8" --f403045c8b5c3bb81b05620c68a8 Content-Type: text/plain; charset="UTF-8" well....max line length as 100 is adopted in many projects (nearly all projects I have been involved or used or looked at, spark/flink/bahir/atlas, etc. companies which using scala intensively also sets it to 100 (e.g. netflix, you can check their atlas project)) one of the reasons is that all these projects are all following https://github.com/databricks/scala-style-guide which was published in the early days of when scala is becoming popular and the behind reason might be that considering the language characteristics of scala, a shorter line limit would be make it more readable, (http://docs.scala-lang.org/style/indentation.html#line-wrapping, the official guide even says 80 as the limit) Also note that, scala-packages has a scala-style plugin regulating coding style which does not apply limits for certain cases, e.g. import, and the developer can turn off style checking if you are doing something special BTW, considering monitor-relevant concern, http://scalameta.org/scalafmt/ tells that 100 is good enough even for a 30'' wide monitor On Fri, Jan 5, 2018 at 11:10 AM, Chris Olivier wrote: > Why -1? > > On Fri, Jan 5, 2018 at 11:03 AM, Nan Zhu wrote: > > > -1 for scala part > > > > On Fri, Jan 5, 2018 at 9:48 AM, Marco de Abreu < > > marco.g.abreu@googlemail.com > > > wrote: > > > > > +1 > > > > > > Am 05.01.2018 5:49 nachm. schrieb "Chris Olivier" < > cjolivier01@gmail.com > > >: > > > > > > +1 > > > > > > On Fri, Jan 5, 2018 at 8:00 AM, Pedro Larroy < > > pedro.larroy.lists@gmail.com > > > > > > > wrote: > > > > > > > Hi > > > > > > > > Can we please increase the indent limit from 100 to 120? I find 100 > > > > too low for current standards and today's monitors. Default CLion > line > > > > limit is also 120. > > > > > > > > I'm having to split some long templates and I wish we had a longer > line > > > > limit. > > > > > > > > Thanks a lot. > > > > > > > > Pedro > > > > > > > > > > --f403045c8b5c3bb81b05620c68a8--