mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nan Zhu <zhunanmcg...@gmail.com>
Subject Re: Increase indentation limit from 100 to 120 characters
Date Fri, 05 Jan 2018 19:25:10 GMT
well....max line length as 100 is adopted in many projects (nearly all
projects I have been involved or used or looked at,
spark/flink/bahir/atlas, etc. companies which using scala intensively also
sets it to 100 (e.g. netflix, you can check their atlas project))

one of the reasons is that all these projects are all following
https://github.com/databricks/scala-style-guide which was published in the
early days of when scala is becoming popular

and the behind reason might be that considering the language
characteristics of scala, a shorter line limit would be make it more
readable, (http://docs.scala-lang.org/style/indentation.html#line-wrapping,
the official guide even says 80 as the limit)

Also note that, scala-packages has a scala-style plugin regulating coding
style which does not apply limits for certain cases, e.g. import, and the
developer can turn off style checking if you are doing something special


BTW, considering monitor-relevant concern, http://scalameta.org/scalafmt/
tells that 100 is good enough even for a 30'' wide monitor




On Fri, Jan 5, 2018 at 11:10 AM, Chris Olivier <cjolivier01@gmail.com>
wrote:

> Why -1?
>
> On Fri, Jan 5, 2018 at 11:03 AM, Nan Zhu <zhunanmcgill@gmail.com> wrote:
>
> > -1 for scala part
> >
> > On Fri, Jan 5, 2018 at 9:48 AM, Marco de Abreu <
> > marco.g.abreu@googlemail.com
> > > wrote:
> >
> > > +1
> > >
> > > Am 05.01.2018 5:49 nachm. schrieb "Chris Olivier" <
> cjolivier01@gmail.com
> > >:
> > >
> > > +1
> > >
> > > On Fri, Jan 5, 2018 at 8:00 AM, Pedro Larroy <
> > pedro.larroy.lists@gmail.com
> > > >
> > > wrote:
> > >
> > > > Hi
> > > >
> > > > Can we please increase the indent limit from 100 to 120? I find 100
> > > > too low for current standards and today's monitors. Default CLion
> line
> > > > limit is also 120.
> > > >
> > > > I'm having to split some long templates and I wish we had a longer
> line
> > > > limit.
> > > >
> > > > Thanks a lot.
> > > >
> > > > Pedro
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message