mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marco de Abreu <marco.g.ab...@googlemail.com>
Subject Re: Proposal for treating warnings as errors in Linux & Clang builds (-Werror)
Date Mon, 15 Jan 2018 17:43:16 GMT
+1

On Mon, Jan 15, 2018 at 6:27 PM, Pedro Larroy <pedro.larroy.lists@gmail.com>
wrote:

> Hi
>
> I would like to propose to compile in CI with warnings as errors for
> increased code quality. This has a dual purpose:
>
> 1. Enforce a clean compilation output. Warnings often indicate
> deficiencies in the code and hide new warnings which can be an
> indicator of problems.
>
> 2. Warnings can surface bugs as has happened before.
>
> While this might be impractical in all architectures, I would propose
> having the Linux and Clang build run without warnings in CI.
>
> I think we are very close to this as I personally have been fixing
> warnings in Linux and OSX / Clang.
>
> References:
>
> https://github.com/apache/incubator-mxnet/pull/9398
>
> http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/
> incubator-mxnet/detail/PR-9398/1/pipeline
>
> Pedro.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message