Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 597A3200D52 for ; Sat, 2 Dec 2017 19:04:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 57D80160BFB; Sat, 2 Dec 2017 18:04:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9CA57160BEA for ; Sat, 2 Dec 2017 19:04:55 +0100 (CET) Received: (qmail 81999 invoked by uid 500); 2 Dec 2017 18:04:54 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 81988 invoked by uid 99); 2 Dec 2017 18:04:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Dec 2017 18:04:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0A0AE180874 for ; Sat, 2 Dec 2017 18:04:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.521 X-Spam-Level: X-Spam-Status: No, score=-2.521 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, HTML_OBFUSCATE_05_10=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id agL2Qt2AHiSv for ; Sat, 2 Dec 2017 18:04:52 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id BA52C5F47D for ; Sat, 2 Dec 2017 18:04:51 +0000 (UTC) Received: (qmail 81985 invoked by uid 99); 2 Dec 2017 18:04:51 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Dec 2017 18:04:51 +0000 Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 7A6FF1A00E0 for ; Sat, 2 Dec 2017 18:04:50 +0000 (UTC) Received: by mail-wm0-f46.google.com with SMTP id 9so8463487wme.4 for ; Sat, 02 Dec 2017 10:04:49 -0800 (PST) X-Gm-Message-State: AJaThX6k9AMR+KAvT/JcgdHA+hR29NR1mUYxazVouK0pwAg4+zVCGolT NiUF8duEjqBxo/m3xOuixFqqAUnsMhYD1YGhPCc= X-Google-Smtp-Source: AGs4zMZyYSzO5cfXftfzPiD22AAnAuD7kBfJJjtjHBcE+04u+VbjUpOw0Lq07q2qxPylesaO2bKdd9kqL3ZIwQU4YO8= X-Received: by 10.80.145.14 with SMTP id e14mr23770933eda.34.1512237888474; Sat, 02 Dec 2017 10:04:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.195.1 with HTTP; Sat, 2 Dec 2017 10:04:47 -0800 (PST) In-Reply-To: References: From: CodingCat Date: Sat, 2 Dec 2017 10:04:47 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: request for reviewing PR in ps-lite To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="f403045c53342895a9055f5f520f" archived-at: Sat, 02 Dec 2017 18:04:56 -0000 --f403045c53342895a9055f5f520f Content-Type: text/plain; charset="UTF-8" ping On Fri, Dec 1, 2017 at 12:18 AM, Nan Zhu wrote: > Hi, all > > I have been working on integrating MXNet with Spark in a more full-fledged > manner. > > One of the most critical pre-conditions is to make parameter server in > mxnet support multiple workers per process. I created the PR in > https://github.com/dmlc/ps-lite/pull/121 (OK, sorry for being late....I > should have finished it earlier) > > This PR includes some refactoring of those too long methods, to highlight > the changes > > 1. https://github.com/dmlc/ps-lite/pull/112 includes the changes related > to refactoring > > 2. https://github.com/CodingCat/ps-lite/pull/3/files includes the changes > related to the key functionality > > 3. https://github.com/dmlc/ps-lite/pull/121 contains everything (Please > review this one) > > > I am not sure who is the current owner of ps-lite, please help to share > your thoughts on the implementation. Only after this PR is merged and > ps-lite version is synced in mxnet repo, I can file the successive PRs in > mxnet > > Thank you very much! > > Nan > --f403045c53342895a9055f5f520f--