Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mxnet.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CAFdgvPG5Y6j6CJs0YvMg7GyZmMvo9cpkt+9Dc5LGChiSrDXYOA@mail.gmail.com>
References: <CAFdgvPG5Y6j6CJs0YvMg7GyZmMvo9cpkt+9Dc5LGChiSrDXYOA@mail.gmail.com>
From: Marco de Abreu <marco.g.abreu@googlemail.com>
Date: Sat, 16 Dec 2017 02:11:47 +0100
Message-ID: <CAHTWJDPOpbzuYCajzDMnwn-Zfs_3XX892BN-a7-0zChKgUpG7Q@mail.gmail.com>
Subject: Re: Apache MXNet Development Processes: Proposed update
To: dev@mxnet.incubator.apache.org
Content-Type: multipart/alternative; boundary="001a11405a742421f905606acdcc"
archived-at: Sat, 16 Dec 2017 01:11:53 -0000

--001a11405a742421f905606acdcc
Content-Type: text/plain; charset="UTF-8"

+1

Additionally, we might make use of the GitHub review feature and add the
restriction that a PR can only be merged if it passed the required CI
checks and has at least one approval.

Am 16.12.2017 2:00 vorm. schrieb "Bhavin Thaker" <bhavinthaker@gmail.com>:

> Hi All,
>
> I would like to propose the following change to the Development process for
> Apache MXNet documented here:
>
> https://cwiki.apache.org/confluence/display/MXNET/Development+Process
>
> Proposed but NOT agreed upon yet:
>
>
>
>    -
>
>    a) It is NOT recommended for a committer to merge pull requests that the
>    committer authored. Instead the committer MUST get at least one approval
>    from another committer to merge his/her pull request.
>
>
>    - b) When you update a pull request with upstream, you MUST use rebase
>    to ensure that the pull request is easy to review by the community. See
> the
>    how-to link here:
>    https://mxnet.incubator.apache.org/community/contribute.html
>
>
> Please vote and provide your feedback.
>
> Regards,
> Bhavin Thaker.
>

--001a11405a742421f905606acdcc--