mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Markus Weimer <mar...@weimo.de>
Subject Re: Apache MXNet Development Processes: Proposed update
Date Sat, 16 Dec 2017 01:37:26 GMT
On Fri, Dec 15, 2017 at 5:00 PM, Bhavin Thaker <bhavinthaker@gmail.com>
wrote:

>    a) It is NOT recommended for a committer to merge pull requests that the
>    committer authored. Instead the committer MUST get at least one approval
>    from another committer to merge his/her pull request.
>

+1


>    - b) When you update a pull request with upstream, you MUST use rebase
>    to ensure that the pull request is easy to review by the community. See
> the
>    how-to link here:
>    https://mxnet.incubator.apache.org/community/contribute.html


Doesn't this potentially erase the review history on GitHub?

Markus

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message