mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marco de Abreu <marco.g.ab...@googlemail.com>
Subject Re: Apache MXNet Development Processes: Proposed update
Date Sat, 16 Dec 2017 07:50:18 GMT
Sorry for the empty email, misclicked.

Am 16.12.2017 8:49 vorm. schrieb "Marco de Abreu" <
marco.g.abreu@googlemail.com>:

>
> Am 16.12.2017 8:47 vorm. schrieb "Naveen Swamy" <mnnaveen@gmail.com>:
>
>> +1.
>>
>> I think the author should also allow maintainers to edit the files, so
>> they
>> can make small changes if necessary(update docs, etc.,)
>>
>> https://help.github.com/articles/allowing-changes-to-a-pull-
>> request-branch-created-from-a-fork/#enabling-repository-
>> maintainer-permissions-on-existing-pull-requests
>>
>>
>> -Naveen
>>
>> On Fri, Dec 15, 2017 at 7:14 PM, pracheer gupta <
>> pracheer_gupta@hotmail.com>
>> wrote:
>>
>> > +1 to all the 3 points (2 from Bhavin, 1 from Marco)
>> >
>> > > On Dec 15, 2017, at 5:37 PM, Markus Weimer <markus@weimo.de> wrote:
>> > >
>> > > On Fri, Dec 15, 2017 at 5:00 PM, Bhavin Thaker <
>> bhavinthaker@gmail.com>
>> > > wrote:
>> > >
>> > >>   a) It is NOT recommended for a committer to merge pull requests
>> that
>> > the
>> > >>   committer authored. Instead the committer MUST get at least one
>> > approval
>> > >>   from another committer to merge his/her pull request.
>> > >>
>> > >
>> > > +1
>> > >
>> > >
>> > >>   - b) When you update a pull request with upstream, you MUST use
>> rebase
>> > >>   to ensure that the pull request is easy to review by the community.
>> > See
>> > >> the
>> > >>   how-to link here:
>> > >>   https://mxnet.incubator.apache.org/community/contribute.html
>> > >
>> > >
>> > > Doesn't this potentially erase the review history on GitHub?
>> > >
>> > > Markus
>> >
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message