Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mxnet.incubator.apache.org
MIME-Version: 1.0
References: <pony-97698aa33826ad442e3b8b13fda48cd8648141ad-7dfcc0bb9525bc86338a1c7f3cd0268ce3afb43f@dev.mxnet.apache.org>
 <pony-97698aa33826ad442e3b8b13fda48cd8648141ad-1457b3f4988a806fd162893b105a5932d4f68340@dev.mxnet.apache.org>
 <CAFgdJKCFAGVF5U_LbxXeJiwy_TS3umy_icyLGZYi=BSrx61z9A@mail.gmail.com>
 <9F69CC84-243C-45FD-A72C-1A540CEFB2B3@gmail.com> <CAHTWJDNcgcZ63DuzvVYNr=9-WShXXmPXBB39B+D7CXN2gTM3gA@mail.gmail.com>
In-Reply-To: <CAHTWJDNcgcZ63DuzvVYNr=9-WShXXmPXBB39B+D7CXN2gTM3gA@mail.gmail.com>
From: Chris Olivier <cjolivier01@gmail.com>
Date: Thu, 30 Nov 2017 20:44:10 +0000
Message-ID: <CABgAAfcV4q+9z1dRjOG3TCU0CFCOqqsY=DE4PQzpXtbf4jbZ4g@mail.gmail.com>
Subject: Re: Protected master needs to be turned off
To: dev@mxnet.incubator.apache.org
Cc: dev@mxnet.apache.org
Content-Type: multipart/alternative; boundary="94eb2c05edd206559a055f39518e"
archived-at: Thu, 30 Nov 2017 20:44:27 -0000

--94eb2c05edd206559a055f39518e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I upvoted turning protected master off now, but just to be fair, and in
case anyone forgot, protected master was turned on because for several
weeks there was a steady stream of bugs pushed into master which caused
unit tests to fail (not just non-deterministic random failures) and it was
adversely effecting both development and infra teams.

On Thu, Nov 30, 2017 at 12:10 PM Marco de Abreu <
marco.g.abreu@googlemail.com> wrote:

> Sounds like a good way to me.
>
> By the way, the setup for the new CI is ready and we=E2=80=99re already v=
erifying
> the master branch. We still need to do some clean up and await the
> Amazon-AppSec review.
>
> On Thu, Nov 30, 2017 at 8:55 PM, Mu Li <limu.cn@gmail.com> wrote:
>
> > I barely remember CI caught bugs except for lint, but it definitely slo=
ws
> > down the code merge.
> >
> > I understand the general concerns for removing master protection. So I
> > propose to use the dev branch to merge changes until the CI is stable.
> And
> > make the nightly build build the dev branch instead of master.
> >
> > Best
> > Mu
> >
> > > On Nov 30, 2017, at 11:34 AM, Gautam <gautamnitc@gmail.com> wrote:
> > >
> > > I believe few of the committers voted -1 and those who favored they
> have
> > > put  pre-condition.
> > > As mentioned before and mentioning again without protected master it
> will
> > > be hard to debug the build failure.
> > > And I am sure everyone here is aware of the challenges which CI faces
> > every
> > > day, not having protected master makes it more difficult.
> > >
> > > -Gautam
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >> On Thu, Nov 30, 2017 at 11:24 AM, Eric Xie <jxie@apache.org> wrote:
> > >>
> > >> Since committers voted for +1. We consider this vote passed.
> > >>
> > >> Thanks,
> > >> Eric
> > >>
> > >>
> > >>
> > >>> On 2017-11-19 12:51, "Eric Xie"<jxie@apache.org> wrote:
> > >>> Hi all,
> > >>> I'm starting this thread to vote on turning off protected master. T=
he
> > >> reasons are:
> > >>>
> > >>> 1. Since we turned on protected master pending PRs has grown from 4=
0
> to
> > >> 80. It is severely slowing down development.
> > >>>
> > >>> 2. Committers, not CI, are ultimately responsible for the code they
> > >> merge. You should only override the CI when you are very confident
> that
> > CI
> > >> is the problem, not your code. If it turns out you are wrong, you
> should
> > >> fix it ASAP. This is the bare minimum requirement for all committers=
:
> BE
> > >> RESPONSIBLE.
> > >>>
> > >>> I'm aware of the argument for using protected master: It make sure
> that
> > >> master is stable.
> > >>>
> > >>> Well, master will be most stable if we stop adding any commits to i=
t.
> > >> But that's not what we want is it?
> > >>>
> > >>> Protected master hardly adds any stability. The faulty tests that
> > breaks
> > >> master at random got merged into master because they happened to
> succeed
> > >> once.
> > >>>
> > >>> Thanks,
> > >>> Junyuan Xie
> > >>>
> > >>
> > >
> > >
> > >
> > > --
> > > Best Regards,
> > > Gautam Kumar
> >
>

--94eb2c05edd206559a055f39518e--