mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steffen Rochel <steffenroc...@gmail.com>
Subject Re: Use unique_ptr on Executor creation
Date Thu, 23 Nov 2017 04:05:54 GMT
-1 (non-binding)
I suggest we go with the proposed content and timeline for 1.0.

Steffen
On Wed, Nov 22, 2017 at 2:58 PM Pedro Larroy <pedro.larroy.lists@gmail.com>
wrote:

> Hi
>
> I would like to make a minor change of the cpp package for 1.0 by
> returning a unique_ptr when creating Engine.
>
> This is a C++ idiom that prevents memory leaks and fixes one leak in
> the examples. As before it requires explicit delete as the ownership
> of the pointer is not clear from the API call.
>
>
>
> https://github.com/apache/incubator-mxnet/pull/8737/files#diff-c0e77771fcfe1619faa4ff5f59d94e8bL341
>
> Please raise any comments if you disagree with this change.
>
> I think it's appropriate to make this change before the 1.0 release
> specially.
>
> Pedro.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message