mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pedro Larroy <pedro.larroy.li...@gmail.com>
Subject Use unique_ptr on Executor creation
Date Wed, 22 Nov 2017 22:58:41 GMT
Hi

I would like to make a minor change of the cpp package for 1.0 by
returning a unique_ptr when creating Engine.

This is a C++ idiom that prevents memory leaks and fixes one leak in
the examples. As before it requires explicit delete as the ownership
of the pointer is not clear from the API call.


https://github.com/apache/incubator-mxnet/pull/8737/files#diff-c0e77771fcfe1619faa4ff5f59d94e8bL341

Please raise any comments if you disagree with this change.

I think it's appropriate to make this change before the 1.0 release specially.

Pedro.

Mime
View raw message