mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Olivier <cjolivie...@gmail.com>
Subject Re: Disable 'required status check' for master
Date Tue, 31 Oct 2017 20:36:05 GMT
I see 73 PR's for mxnet.

17 of those have successfully passed CI and are waiting for merge (assuming
the CR passed human inspection).
21 Show some form of CI in progress.
*Only 8 are in the queue in Jenkins*

The rest have failed CI for one reason or another.




On Tue, Oct 31, 2017 at 1:17 PM, Eric Xie <jxie@apache.org> wrote:

> The number of pending PRs is growing very fast. At the current rate it
> will reach 200 before we can fix jenkins.
>
> Stability is not the only goal. Master will be most stable if we don't
> push anything, but that's not what we want.
>
> Committers should be responsible for their commits. Good judgement is the
> ultimate guarantee of good code.
>
> Thanks,
> Eric
>
> On 2017-10-31 12:38, Chris Olivier <cjolivier01@gmail.com> wrote:
> > -1
> >
> > I personally think it's a necessary evil and a good forcing factor to get
> > CI fixed.
> > Before that requirements, things that failed unit tests were being pushed
> > into master daily.  It was a big problem.  At least now master is stable.
> >
> > On Tue, Oct 31, 2017 at 12:22 PM, Hen <bayard@apache.org> wrote:
> >
> > > This makes sense to me. CI isn't of value if it isn't continuous. +1.
> > >
> > > On Tue, Oct 31, 2017 at 12:07 PM, Indhu <indhubharathi@gmail.com>
> wrote:
> > >
> > > > Hi,
> > > >
> > > > We have been having issues getting CI to work fast enough. Currently
> the
> > > CI
> > > > is being the bottleneck to get commits in. This is severely impacting
> > > > development. I propose we disable 'required status check' for the
> master
> > > > branch so that we can development is not impacted. We can work on
> fixing
> > > > the CI situation in parallel.
> > > >
> > > > Committer,
> > > > Please vote if you are okay with disabling 'required status check'
> for
> > > > master.
> > > >
> > > > Once we have enough votes, I'll request a mentor to file a ticket
> with
> > > > infra.
> > > >
> > > > Thanks,
> > > > Indu
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message