mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Naveen Swamy <mnnav...@gmail.com>
Subject Re: MXNet: Run PR builds on Apache Jenkins only after the commit is reviewed
Date Tue, 12 Sep 2017 01:12:06 GMT
+1

Even a small change in the PR is initiating a new build, I think this is
needless and not serving any good purpose until a reviewer has looked into
the PR. This is also adding unnecessary load on the mxnet build pipeline
and slaves.

Thanks, Naveen


On Mon, Sep 11, 2017 at 5:50 PM, Meghna Baijal <meghnabaijal2017@gmail.com>
wrote:

> Hi All,
> We would like to initiate a change in the way the PR builds are being
> triggered. At the moment, every time a Pull Request is created, a build
> gets triggered on Jenkins. Additional builds also get triggered due to
> changes to the same PR.
> Too many PR builds leads to resource starvation and very long queues and
> long build times. Hence we would like to add some checks where a human
> reviewer manually marks it to something like “ok to build” before a PR
> build is triggered.
>
> Do you think this approach would be helpful and we should move forward
> with it?
>
> Thanks,
> Meghna Baijal
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message