mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Naveen Swamy <mnnav...@gmail.com>
Subject Re: Rcpp licensing in Apache MXNet
Date Wed, 12 Jul 2017 03:21:12 GMT
Ly,
     Can we skip R pkg for the proposed release as KK mentioned and add
it/alter based on the advice we get from ASF legal?

---KK Says---
As I understand, if we skip the R pkg when releasing the a new version of
MXNet, everything is OK. This is can be done by adding a .gitattribute.
---

others,
     thoughts/concerns?

Thanks, Naveen





On Tue, Jul 11, 2017 at 3:56 PM, Ly Nguyen <nguyenlyx@gmail.com> wrote:

> Hey KK,
>
> I know we're planning a release end of this week/beginning of next week. It
> may be critical to get this cleared if it is an issue. Eager to hear back.
> :)
>
> On Tue, Jul 11, 2017 at 3:35 PM, Qiang Kou <qkou@umail.iu.edu> wrote:
>
> > Hi, Ly,
> >
> > I will let you know when I have the answer.
> >
> > Best,
> >
> > KK
> >
> > On Tue, Jul 11, 2017 at 10:50 AM, Ly Nguyen <nguyenlyx@gmail.com> wrote:
> >
> > > Hi @KK, any updates from legal on whether excluding the R pkg is a
> > solution
> > > for our next release?
> > >
> > > On Mon, Jul 10, 2017 at 10:49 AM, Qiang Kou <qkou@umail.iu.edu> wrote:
> > >
> > > > Thank you for the info.
> > > >
> > > > As I understand, if we skip the R pkg when releasing the a new
> version
> > of
> > > > MXNet, everything is OK. This is can be done by adding a
> .gitattribute.
> > > >
> > > > I will ask on legal-discuss@ for more info and confirmation.
> > > >
> > > > Really thank you for all the info! It is super helpful.
> > > >
> > > > Best,
> > > >
> > > > KK
> > > >
> > > >
> > > > On Fri, Jul 7, 2017 at 8:47 AM, Felix Cheung <
> > felixcheung_m@hotmail.com>
> > > > wrote:
> > > >
> > > > > I was only referring to string_hash_code.c - it's not being built
> and
> > > > it's
> > > > > not part of the binaries release.
> > > > >
> > > > > There are two parts to it.
> > > > >
> > > > > For Spark binaries release, R package is built and the output is
> > > packaged
> > > > > along with the rest of all jars  and python stuff.
> > > > >
> > > > > There is also a source-only R package that we want to publish to
> > CRAN.
> > > > > This contains only R source (no java stuff). CRAN will then build
> > cross
> > > > > platform from that source - but again the part with
> > string_hash_code.c
> > > is
> > > > > disabled.
> > > > >
> > > > > I guess we should have removed string_hash_code.c from source but
> we
> > > are
> > > > > secretly hoping we could sort that out at some point in the
> future..
> > > (ie.
> > > > > building cross platform)
> > > > >
> > > > >
> > > > > _____________________________
> > > > > From: Qiang Kou <qkou@umail.iu.edu<mailto:qkou@umail.iu.edu>>
> > > > > Sent: Friday, July 7, 2017 8:34 AM
> > > > > Subject: Re: Rcpp licensing in Apache MXNet
> > > > > To: <dev@mxnet.incubator.apache.org<mailto:dev@mxnet.
> > > > incubator.apache.org
> > > > > >>
> > > > >
> > > > >
> > > > > Really thank you for the info.
> > > > >
> > > > > Can you tell us a little more on how Spark handles the R package?
> > > > >
> > > > > The building of R package is skipped when releasing, right?
> > > > >
> > > > > Best wishes,
> > > > >
> > > > > KK
> > > > >
> > > > > On Fri, Jul 7, 2017 at 7:41 AM, Felix Cheung <
> > > felixcheung_m@hotmail.com<
> > > > > mailto:felixcheung_m@hotmail.com>>
> > > > > wrote:
> > > > >
> > > > > > Re this
> > > > > >
> > > > > > The Spark R package includes "R.h" and "Rinternals.h", which
are
> > both
> > > > > LGPL
> > > > > > (
> > > > > > https://github.com/apache/spark/blob/master/R/pkg/src-
> > > > > > native/string_hash_code.c#L24-L25
> > > > > > ).
> > > > > >
> > > > > > This is actually disabled - it is not getting built and it is
not
> > in
> > > > the
> > > > > > release - because the way SparkR is packaged in Spark release
we
> > > > haven't
> > > > > > figured out how to release cross multiple platforms.
> > > > > >
> > > > > > (I'm one of the main contributor to SparkR)
> > > > > >
> > > > > > ________________________________
> > > > > > From: Henri Yandell <bayard@apache.org<mailto:bayard@apache.org
> >>
> > > > > > Sent: Friday, July 7, 2017 12:02:16 AM
> > > > > > To: dev@mxnet.incubator.apache.org<mailto:dev@mxnet.incubator.
> > > > apache.org
> > > > > >
> > > > > > Subject: Re: Rcpp licensing in Apache MXNet
> > > > > >
> > > > > > We should bring this up on general@incubator or legal-discuss@.
> > > > > >
> > > > > > On Thu, Jul 6, 2017 at 10:59 PM, Qiang Kou <qkou@umail.iu.edu
> > > <mailto:
> > > > > qkou@umail.iu.edu>> wrote:
> > > > > >
> > > > > > > Really thank you for the clearance.
> > > > > > >
> > > > > > > From the link you provided,
> > > > > > >
> > > > > > > "However, if the component is only needed for optional
> features,
> > a
> > > > > > project
> > > > > > > can provide the user with instructions on how to obtain
and
> > install
> > > > the
> > > > > > > non-included work."
> > > > > > >
> > > > > > > I think this is exactly our case. We provide instructions
on
> how
> > to
> > > > > > install
> > > > > > > GNU R and the Rcpp package.
> > > > > > >
> > > > > > > Besides, our case is very similar with Spark.
> > > > > > >
> > > > > > > The Spark R package includes "R.h" and "Rinternals.h",
which
> are
> > > both
> > > > > > LGPL
> > > > > > > (
> > > > > > > https://github.com/apache/spark/blob/master/R/pkg/src-
> > > > > > > native/string_hash_code.c#L24-L25
> > > > > > > ).
> > > > > > >
> > > > > > > Best wishes,
> > > > > > >
> > > > > > > Qiang Kou
> > > > > > >
> > > > > > > On Thu, Jul 6, 2017 at 6:09 PM, Felix Cheung <
> > > > > felixcheung_m@hotmail.com<mailto:felixcheung_m@hotmail.com>>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > I'm not the authority on this but a release from an
ASF
> project
> > > is
> > > > > > > > different from releasing with the Apache 2.0 license.
> > > > > > > >
> > > > > > > > You can find more out this here
> > > > > > > > https://www.apache.org/legal/resolved.html#optional
> > > > > > > >
> > > > > > > > Specifically, quote:
> > > > > > > > "Optional means that the component is not required
for
> standard
> > > use
> > > > > of
> > > > > > > the
> > > > > > > > product or for the product to achieve a desirable
level of
> > > > quality."
> > > > > > > >
> > > > > > > > Basically my interpretation is that if an ASF project
cannot
> > > > function
> > > > > > > > without a component, then it is required and such
required
> > > > component
> > > > > > > cannot
> > > > > > > > be one of the prohibited licenses.
> > > > > > > >
> > > > > > > > https://www.apache.org/legal/resolved.html#category-x
> > > > > > > >
> > > > > > > > Probably a good idea to start a thread with legal@
if there
> > are
> > > > more
> > > > > > > > questions.
> > > > > > > >
> > > > > > > > _____________________________
> > > > > > > > From: Qiang Kou <qkou@umail.iu.edu<mailto:qkou@umail.iu.edu
> > > > ><mailto:
> > > > > qkou@umail.iu.edu>>
> > > > > > > > Sent: Thursday, July 6, 2017 3:41 PM
> > > > > > > > Subject: Re: Rcpp licensing in Apache MXNet
> > > > > > > > To: <dev@mxnet.incubator.apache.org<mailto:dev@mxnet.
> > > > > incubator.apache.org><mailto:dev@mxnet.
> > > > > > > incubator.apache.org<http://incubator.apache.org>
> > > > > > > > >>
> > > > > > > >
> > > > > > > >
> > > > > > > > Hi, Felix,
> > > > > > > >
> > > > > > > > I just want to make sure there is no misunderstanding
between
> > us.
> > > > > > > >
> > > > > > > > (1) The MXNet R package heavily used the Rcpp package,
but we
> > > only
> > > > > > > include
> > > > > > > > the
> > > > > > > > header file, Rcpp.h, like https://github.com/dmlc/mxnet/
> > > > > > > > blob/master/R-package/src/base.h#L11
> > > > > > > >
> > > > > > > > The MXNet R package doesn't contain any source code
from Rcpp
> > and
> > > > > there
> > > > > > > is
> > > > > > > > no linking against Rcpp.
> > > > > > > >
> > > > > > > > (2) There is "LinkingTo: Rcpp" in the R package description
(
> > > > > > > > https://github.com/dmlc/mxnet/blob/master/R-package/
> > > > DESCRIPTION#L32
> > > > > ).
> > > > > > > > However, this only means we want to use the header
files from
> > > Rcpp.
> > > > > > > >
> > > > > > > > "A package that wishes to make use of header files
in other
> > > > > > > > packages needs to declare them as a
> > > > > > > > comma-separated list in the field ‘LinkingTo’
in the
> > DESCRIPTION
> > > > > file.
> > > > > > "
> > > > > > > >
> > > > > > > > More details can be found from R's official manual
(
> > > > > > > > https://cran.r-project.org/doc/manuals/r-release/R-exts.
> > > > > > > > html#Package-Dependencies).
> > > > > > > >
> > > > > > > > (3) Many R packages who use Rcpp to communicate with
C++ have
> > > been
> > > > > > > released
> > > > > > > > under Apache License, like feather (https://github.com/wesm/
> > > > > > > > feather/blob/master/R/DESCRIPTION).
> > > > > > > >
> > > > > > > > Best,
> > > > > > > >
> > > > > > > > Qiang Kou
> > > > > > > >
> > > > > > > > On Thu, Jul 6, 2017 at 1:20 AM, Felix Cheung <
> > > > > > felixcheung_m@hotmail.com<mailto:felixcheung_m@hotmail.com><
> > > > > > > > mailto:felixcheung_m@hotmail.com>>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > On a related note, Rcpp, used extensively in
the R package,
> > is
> > > > > > > > GPLv2/GPLv3
> > > > > > > > > licensed.
> > > > > > > > >
> > > > > > > > > I'm not aware of any other R package available
that
> supports
> > > > > R<->C++.
> > > > > > > > >
> > > > > > > > > https://www.apache.org/legal/resolved.html#category-x
> > > > > > > > > https://cran.r-project.org/web/packages/Rcpp/index.html
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Qiang Kou
> > > > > > > qkou@umail.iu.edu<mailto:qkou@umail.iu.edu>
> > > > > > > School of Informatics and Computing, Indiana University
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Qiang Kou
> > > > > qkou@umail.iu.edu<mailto:qkou@umail.iu.edu>
> > > > > School of Informatics and Computing, Indiana University
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Qiang Kou
> > > > qkou@umail.iu.edu
> > > > School of Informatics and Computing, Indiana University
> > > >
> > >
> >
> >
> >
> > --
> > Qiang Kou
> > qkou@umail.iu.edu
> > School of Informatics and Computing, Indiana University
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message