From commits-return-129640-archive-asf-public=cust-asf.ponee.io@mxnet.apache.org Mon Aug 3 16:33:24 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id B6220180642 for ; Mon, 3 Aug 2020 18:33:24 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id E4D86124AA5 for ; Mon, 3 Aug 2020 16:33:23 +0000 (UTC) Received: (qmail 48723 invoked by uid 500); 3 Aug 2020 16:33:23 -0000 Mailing-List: contact commits-help@mxnet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.apache.org Delivered-To: mailing list commits@mxnet.apache.org Received: (qmail 48714 invoked by uid 99); 3 Aug 2020 16:33:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2020 16:33:23 +0000 From: =?utf-8?q?GitBox?= To: commits@mxnet.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-mxnet=5D_leezu_commented_on_issue_=23188?= =?utf-8?q?40=3A_MacOS_nightly_build_broken_?= Message-ID: <159647240367.32230.902558738506017455.asfpy@gitbox.apache.org> Date: Mon, 03 Aug 2020 16:33:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: leezu commented on issue #18840: URL: https://github.com/apache/incubator-mxnet/issues/18840#issuecomment-668119673 Actually it's changed to static linkage @szha: https://github.com/apache/incubator-mxnet/blob/51340d8f40721e03938e0021c6cbb557a44dd90e/CMakeLists.txt#L157 The problem is though that there is a `AND NOT APPLE` in the `if` condition. Need to move the static linkage option to a separate if clause. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org