mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] ys2843 commented on pull request #18845: Fixed python website double scroller and improve UX
Date Mon, 03 Aug 2020 06:28:09 GMT

ys2843 commented on pull request #18845:
URL: https://github.com/apache/incubator-mxnet/pull/18845#issuecomment-667830263


   > @ys2843 thanks for the fix! I verified that the double scroller problem is gone and
the page seems to run smoother too.
   > I tried page-up and page-down but it still doesn't seem to work unless I click on
the inner div to adjust the focus first. Is there any way to make page scrolling with keyboard
work too?
   
   Thanks for reviewing, the keyboard control depends on the focused element. I added a fix
to auto focus the content element when the pages finish rendering. Please see the (updated)
preview.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message