mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18738: set website default version - test redirect
Date Fri, 17 Jul 2020 23:51:39 GMT

ys2843 edited a comment on pull request #18738:

   > Not sure, but this didn't work:
   > Shouldn't the dropdown read 1.6 if the redirect worked?
   > You can use the beta site for testing redirects. It's perfect for this kind of testing.
   I will add more clarification about this PR. The only working redirect in this PR for testing
is described below
   The redirect only works when user enter `/versions/1.1.0/community/contribute.html` from
outside of mxnet website. It could be from a google search result, or type this url into the
browser directly. ( check HTTP `referer` is "" or not)
   And to prevent redirect looping, if user goes to `/versions/1.1.0` => top nav bar =>
community => contribute, this also goes to contribution page but redirect won't be triggered
because user is coming from mxnet website.
   Thanks for the suggestion, I will test it on beta site.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message