mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #18239: Make GPU kernel for argsort use int32
Date Thu, 07 May 2020 00:44:31 GMT

access2rohit commented on a change in pull request #18239:
URL: https://github.com/apache/incubator-mxnet/pull/18239#discussion_r421173487



##########
File path: src/operator/tensor/ordering_op-inl.h
##########
@@ -190,8 +191,8 @@ using namespace mshadow;
 
 
 struct fill_ind_to_one {
-  template<typename DType>
-  MSHADOW_XINLINE static void Map(int i, const index_t* indices, DType* out) {

Review comment:
       makes sense will take a look at the use case and update the PR if required else update
why its not necessary




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message