mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] larroy commented on a change in pull request #17448: cmake: staticbuild for binary distribution
Date Tue, 28 Jan 2020 21:33:03 GMT
larroy commented on a change in pull request #17448: cmake: staticbuild for binary distribution
URL: https://github.com/apache/incubator-mxnet/pull/17448#discussion_r372069842
 
 

 ##########
 File path: tools/staticbuild/build_lib_cmake.sh
 ##########
 @@ -0,0 +1,64 @@
+#!/usr/bin/env bash
 
 Review comment:
   set -eo pipefail . ?
   
   
   maybe better in python?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message