mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #17265: Add bfloat16 floating-point format support based on AMP
Date Tue, 14 Jan 2020 07:42:04 GMT
eric-haibin-lin commented on a change in pull request #17265: Add bfloat16 floating-point format
support based on AMP 
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r366188211
 
 

 ##########
 File path: src/engine/naive_engine.cc
 ##########
 @@ -55,7 +55,7 @@ class NaiveEngine final : public Engine {
     std::vector<VarHandle> const_vars;
     std::vector<VarHandle> mutable_vars;
     FnProperty prop;
-    const char* opr_name;
+    std::string opr_name;
 
 Review comment:
   I don't think it's merged yet. I'm ok with the change here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message